Skip to content

[Translator] Remove deprecated feature #24014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2017
Merged

[Translator] Remove deprecated feature #24014

merged 1 commit into from
Aug 31, 2017

Conversation

maidmaid
Copy link
Contributor

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets /
License MIT
Doc PR /

@chalasr
Copy link
Member

chalasr commented Aug 28, 2017

I suggest to review this one after #23667.

@maidmaid
Copy link
Contributor Author

maidmaid commented Aug 28, 2017 •
edited
Loading

Ok, but #23667 does not seem to affect the TranslationWriter like here.

@nicolas-grekas nicolas-grekas added this to the 4.0 milestone Aug 29, 2017
chalasr
chalasr approved these changes Aug 29, 2017
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#23667 BC layers removed during merge.

@nicolas-grekas
Copy link
Member

Thank you @maidmaid.

@nicolas-grekas nicolas-grekas merged commit cce2dd1 into symfony:master Aug 31, 2017
nicolas-grekas added a commit that referenced this pull request Aug 31, 2017
@nicolas-grekas
feature #24014 [Translator] Remove deprecated feature (maidmaid)
3ff0ff0 
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Translator] Remove deprecated feature

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Commits
-------

cce2dd1 Remove deprecated feature
@maidmaid maidmaid deleted the translator-4 branch August 31, 2017 14:25
@fabpot fabpot mentioned this pull request Oct 19, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
BC Break Status: Needs Review Translation
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@maidmaid @chalasr @nicolas-grekas @carsonbot