Skip to content

[VarDumper] Fix segfault in period caster #24023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2017

Conversation

maidmaid
Copy link
Contributor

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23668 (comment)
License MIT
Doc PR /

This segfault was fixed in 5.6.20 and in 7.0.5.

Issue in action here: https://3v4l.org/DhOdT#v565

@maidmaid maidmaid force-pushed the vardumper-segfault branch from 71aefac to d84e9c8 Compare August 29, 2017 15:37
@maidmaid maidmaid changed the title [WIP][VarDumper] Fix segfault in period caster [VarDumper] Fix segfault in period caster Aug 29, 2017
@maidmaid
Copy link
Contributor Author

Green tests! ping @nicolas-grekas

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 29, 2017
@nicolas-grekas
Copy link
Member

Thank you @maidmaid.

@nicolas-grekas nicolas-grekas merged commit d84e9c8 into symfony:3.4 Aug 29, 2017
nicolas-grekas added a commit that referenced this pull request Aug 29, 2017
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Fix segfault in period caster

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23668 (comment)
| License       | MIT
| Doc PR        | /

[This segfault](https://bugs.php.net/bug.php?id=71635) was fixed in [5.6.20](http://www.php.net/ChangeLog-5.php#5.6.20) and in [7.0.5](http://www.php.net/ChangeLog-7.php#7.0.5).

Issue in action here: https://3v4l.org/DhOdT#v565

Commits
-------

d84e9c8 Fix segfault in period caster
@maidmaid maidmaid deleted the vardumper-segfault branch August 29, 2017 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants