[Lock] Make SemaphoreStore::isSupported() internal #24057
Conversation
| @@ -33,6 +33,10 @@ class SemaphoreStore implements StoreInterface | |||
| */ | |||
| public static function isSupported($blocking = null) | |||
| { | |||
| if (null !== $blocking) { | |||
| @trigger_error(sprintf('The "$blocking" argument of the "%s" is deprecated since 3.4 and will be removed in 4.0.', __METHOD__), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Internal call should not trigger deprecation (this argument is used by component console)
There was a problem hiding this comment.
But how know if call is internal or not?
There was a problem hiding this comment.
By passing false as second (extra, implicit) argument in each internal call, then triggering only if 1 === func_num_args() || func_get_arg(1). But wait, @jderusse do we really need to expose this argument in 3.4? Would it be enough to not add it and consider it exists only for internal calls?
There was a problem hiding this comment.
let's make it final and move on :)
There was a problem hiding this comment.
@nicolas-grekas doesn't #24053 (comment) still apply when calling the method (no inheritance)?
There was a problem hiding this comment.
nothing will break, so we don't care
There was a problem hiding this comment.
I would just mark this method as @internal
| @@ -5,3 +5,4 @@ CHANGELOG | |||
| ----- | |||
|
|
|||
| * added the component | |||
| * deprecated the `$blocking` argument of the `SemaphoreStore::isSupported()` method | |||
There was a problem hiding this comment.
Thé component is not released yet. Does it make sense to deprecate things here?
There was a problem hiding this comment.
It's usefull to see deprecations linked to 3.4 here I think, else no textual informations is written elsewhere.
There was a problem hiding this comment.
Lock was not part of 3.3, so there is nothing to deprecate.
|
Thank you @maidmaid. |
…maid) This PR was merged into the 3.4 branch. Discussion ---------- [Lock] Make SemaphoreStore::isSupported() internal | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24053 (comment) | License | MIT | Doc PR | / Commits ------- 86f2f25 Mark SemaphoreStore::isSupported() as internal
Uh oh!
There was an error while loading. Please reload this page.