-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[TwigBridge] Show Twig's loader paths on debug:twig command #24064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fb340ef
to
40a4bb3
Compare
I have another outputs for this list, which do you prefer?
|
For the record, I prefer the current version (A). |
Outputting namespace first looks better to me (so A), as what is important is the different paths related to a given namespace. Paths used for separate namespaces are irrelevant regarding their order |
Updated screenshot in description with the latest changes. |
I find using Which of the following outputs would you prefer? My own vote would go to 4 or 5 (but 7's not bad, that's true 😄). |
The problem I see with no row separator is that there is no grouping view per namespace, so one could get confused (missing namespace 😕) |
My vote is for 7. |
What about a 7 is nice, agree with @yceruto; you getter a better view of path inheritance per namespace. Tend to prefer edit: on 2nd thought (None) is fine :) |
ac2a2ce
to
ddde74f
Compare
Thank you @yceruto. |
…mmand (yceruto) This PR was squashed before being merged into the 3.4 branch (closes #24064). Discussion ---------- [TwigBridge] Show Twig's loader paths on debug:twig command | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - `bin/console debug:twig`:  This information is not displayed anywhere ATM and it should be important to know: * The Twig's namespaces availables * The Twig's paths availables * The order that templates will be loaded ( regarding its namespace -> LOAD PRIORITY ! ) So it should help us to debug any issue related to circular templates reference, invalid namespaces, unsuccessful attempt to override a template, etc. WDYT? Commits ------- 3fdcb40 [TwigBridge] Show Twig's loader paths on debug:twig command
bin/console debug:twig
:This information is not displayed anywhere ATM and it should be important to know:
So it should help us to debug any issue related to circular templates reference, invalid namespaces, unsuccessful attempt to override a template, etc.
WDYT?