[HttpKernel] Deprecate EnvParametersResource #24068
Conversation
|
It should be just deprecated, the implementation doesn't fit any generic use case - and we now have real env vars. |
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| use Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator; | |||
| use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper; | |||
| use Symfony\Component\Config\Resource\EnvParametersResource; | |||
There was a problem hiding this comment.
please revert ordering changes
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| use Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator; | |||
| use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper; | |||
| use Symfony\Component\Config\Resource\EnvParametersResource; | |||
There was a problem hiding this comment.
please revert ordering changes
|
Do you propose to soft deprecate it in 3.4? Core would still use it. |
|
Sounds good yes |
|
Done. |
|
Can you add an entry in UPGRADE-4.0 about the removal? |
|
If this goes first, i can do that in #24067. Along with the actual removal :) edit: or do we care about the state of UPGRADE-4.0 in 3.4? |
|
I'd say no, just to not forgot about it. |
|
Which raises the question; do we need that file in 3.4 anyway? If you should follow the master version |
|
I would update the 4.0 UPGRADE file in this PR, that's what we've been doing for years :) |
|
@ro0NL If the author doesn't do the removing PR (or if we remove while merging up) it's good to have this file already up to date. |
Yeah but without the actual code change it's technically not true (yet) :) I see the POV, and as long as lowest branch is leading there's no real issue. Just wanted to point out it can be fragile, and maintaining a single version of truth might make sense :) @fabpot it already went wrong :) https://www.diffchecker.com/vQeHcX37 basically the same file is out of sync between branches. Updated anyway :) |
|
Thank you @ro0NL. |
This PR was squashed before being merged into the 3.4 branch (closes #24068). Discussion ---------- [HttpKernel] Deprecate EnvParametersResource | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> See #24067 Commits ------- 76ea6df [HttpKernel] Deprecate EnvParametersResource
See #24067