Skip to content

Fix ArrayInput::toString() for VALUE_IS_ARRAY options/args #24096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2017
Merged

Fix ArrayInput::toString() for VALUE_IS_ARRAY options/args #24096

merged 1 commit into from
Sep 5, 2017

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Sep 4, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24087
License MIT
Doc PR n/a

@chalasr chalasr added this to the 2.7 milestone Sep 4, 2017
@chalasr chalasr changed the base branch from master to 2.7 September 4, 2017 20:35
@chalasr chalasr force-pushed the arrayinput-tostring branch from 2c65752 to 2ba5005 Compare September 4, 2017 20:36
@chalasr chalasr mentioned this pull request Sep 4, 2017
Closed
@dominikzogg
Copy link
Contributor

@chalasr thank you

@fabpot
Copy link
Member

fabpot commented Sep 5, 2017

Thank you @chalasr.

@fabpot fabpot merged commit 2ba5005 into symfony:2.7 Sep 5, 2017
fabpot added a commit that referenced this pull request Sep 5, 2017
@fabpot
bug #24096 Fix ArrayInput::toString() for VALUE_IS_ARRAY options/args…
fd568ac 
… (chalasr)

This PR was merged into the 2.7 branch.

Discussion
----------

Fix ArrayInput::toString() for VALUE_IS_ARRAY options/args

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24087
| License       | MIT
| Doc PR        | n/a

Commits
-------

2ba5005 Fix ArrayInput::toString() for VALUE_IS_ARRAY options/args
@chalasr chalasr deleted the arrayinput-tostring branch September 5, 2017 23:18
@fabpot fabpot mentioned this pull request Sep 11, 2017
Merged
This was referenced Oct 5, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@javiereguiluz javiereguiluz javiereguiluz approved these changes

Assignees
No one assigned
Labels
Bug Console Status: Needs Review
Projects
None yet
Milestone
2.7
Development

Successfully merging this pull request may close these issues.
4 participants
@chalasr @dominikzogg @fabpot @javiereguiluz