[FrameworkBundle] Get KERNEL_CLASS through $_ENV too for KernelTestCase #24113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Sep 6, 2017
fabpot
requested changes
Sep 6, 2017
| @@ -106,16 +106,17 @@ private static function getPhpUnitCliConfigArgument() | |||
| */ | |||
| protected static function getKernelClass() | |||
| { | |||
| if (isset($_SERVER['KERNEL_CLASS'])) { | |||
| if (!class_exists($class = $_SERVER['KERNEL_CLASS'])) { | |||
| if (isset($_SERVER['KERNEL_CLASS']) || isset($_ENV['KERNEL_CLASS'])) { | |||
There was a problem hiding this comment.
This should probably be fixed in 2.7.
There was a problem hiding this comment.
Removed changes regarding to KERNEL_DIR var only, so KERNEL_CLASS was introduced in 3.3.
8d42684 to
73cdb68
Compare
nicolas-grekas
approved these changes
Sep 7, 2017
nicolas-grekas
added a commit
that referenced
this pull request
Sep 7, 2017
…nelTestCase (yceruto) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Get KERNEL_DIR through $_ENV too for KernelTestCase | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See #24113 Commits ------- cf11fb9 Get KERNEL_DIR through $_ENV too for KernelTestCase
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 7, 2017
…ernelTestCase (yceruto) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Get KERNEL_CLASS through $_ENV too for KernelTestCase | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/recipes/pull/170/files#diff-793b024840ee04ebdff5e04c2cd44f8cR12 | License | MIT | Doc PR | - I guess the check could be simplied in `master` with php7+ /cc @nicolas-grekas Commits ------- 73cdb68 Get KERNEL_CLASS through $_ENV too
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess the check could be simplied in
masterwith php7+/cc @nicolas-grekas