[SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall #24114

chalasr · 2017-09-06T22:00:29Z

Q	A
Branch?	3.4
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
Fixed tickets	n/a
License	MIT
Doc PR	n/a

Before

The service "security.authentication.manager" has a dependency on a non-existent service "security.user.provider.concrete.undefined_provider".

After

Invalid firewall "main": user provider "undefined_provider" not found.

nicolas-grekas · 2017-09-07T07:30:56Z

src/Symfony/Bundle/SecurityBundle/DependencyInjection/SecurityExtension.php

@@ -332,6 +332,9 @@ private function createFirewall(ContainerBuilder $container, $id, $firewall, &$a
        // Provider id (take the first registered provider if none defined)
        if (isset($firewall['provider'])) {
            $defaultProvider = $this->getUserProviderId($firewall['provider']);
+            if (!in_array($defaultProvider, $providerIds, true)) {
+                throw new InvalidConfigurationException(sprintf('User provider "%s" used for firewall "%s" does not exist.', $firewall['provider'], $id));


would that be more readable (similar below)?
Invalid firewall "%s": user provider "%s" not found.

👍 should we use the very same message for the case where the provider is configured under a listener (handled below)? I think so

…inside a firewall

fabpot · 2017-09-07T14:47:55Z

Thank you @chalasr.

…undefined user provider is used inside a firewall (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Before > The service "security.authentication.manager" has a dependency on a non-existent service "security.user.provider.concrete.undefined_provider". After > Invalid firewall "main": user provider "undefined_provider" not found. Commits ------- b884c66 Throw a meaningful exception when an undefined user provider is used inside a firewall

mvrhov · 2017-09-07T16:36:44Z

I'm getting this error in project that worked with 2days old 3.4 What else has changed?

mvrhov · 2017-09-07T16:48:33Z

Addon This PR is the culprit for the error. I've checked out 7dfb5aa which is one commit before this one was merged and everything works.

This is the excerpt from the security.yml

security:
    encoders:
        'Foo\Bundle\AccountBundle\Security\User':
            algorithm: bcrypt
    role_hierarchy:
        ROLE_ADMIN:       ROLE_USER
        ROLE_SUPER_ADMIN: [ROLE_ADMIN, ROLE_ALLOWED_TO_SWITCH]
    providers:
        account:
            id: account.security.user_provider
    firewalls:
        dev:
            pattern: ^/(_(profiler|wdt|error|pomm))/
            security: false
        assets:
            pattern: ^/(bundles|compiled)/
            security: false
        default:
            pattern:    .*
            anonymous:  true
            user_checker: account.security.user_checker
            logout:
                path:   /logout
                target: /
                invalidate_session: true
                delete_cookies:
                    PHPSESSID: { path: null, domain: null }
            form_login:
                provider:   account
                login_path: account_security_login
                check_path: account_security_check
                username_parameter: 'login[username]'
                password_parameter: 'login[password]'
            remember_me:
                secret:   '%remember_me_key%'
                lifetime: 2592000 # one month
                path:     /
                domain:   ~ # Defaults to the current domain from $_SERVER
    access_control:
        - { path: ^/login$, role: IS_AUTHENTICATED_ANONYMOUSLY }
        - { path: ^/, role: [IS_AUTHENTICATED_FULLY,IS_AUTHENTICATED_REMEMBERED] }

mvrhov · 2017-09-07T16:50:57Z

@chalasr ping

chalasr · 2017-09-07T17:24:25Z

@mvrhov I'm on it.

chalasr · 2017-09-07T17:30:47Z

Can you try #24132 and confirm it fixes it? Sorry for the inconvenience.

chalasr added DX DX = Developer eXperience (anything that improves the experience of using Symfony) Feature SecurityBundle labels Sep 6, 2017

carsonbot added the Status: Needs Review label Sep 6, 2017

chalasr added this to the 3.4 milestone Sep 6, 2017

nicolas-grekas reviewed Sep 7, 2017

View reviewed changes

Throw a meaningful exception when an undefined user provider is used …

b884c66

…inside a firewall

chalasr force-pushed the secu-dx-missng-provider-error branch from e58bed4 to b884c66 Compare September 7, 2017 08:20

nicolas-grekas approved these changes Sep 7, 2017

View reviewed changes

fabpot approved these changes Sep 7, 2017

View reviewed changes

fabpot merged commit b884c66 into symfony:3.4 Sep 7, 2017

chalasr deleted the secu-dx-missng-provider-error branch September 7, 2017 14:48

raziel057 mentioned this pull request Sep 8, 2017

Firewall with support of JWT and Digest authentication lexik/LexikJWTAuthenticationBundle#384

Closed

This was referenced Oct 18, 2017

Release v3.4.0-BETA1 #24609

Merged

Release v4.0.0-BETA1 #24612

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall #24114

[SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall #24114

chalasr commented Sep 6, 2017 •

edited

Loading

nicolas-grekas Sep 7, 2017

chalasr Sep 7, 2017

nicolas-grekas Sep 7, 2017

fabpot commented Sep 7, 2017

mvrhov commented Sep 7, 2017

mvrhov commented Sep 7, 2017 •

edited

Loading

mvrhov commented Sep 7, 2017

chalasr commented Sep 7, 2017

chalasr commented Sep 7, 2017

[SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall #24114

[SecurityBundle] Throw a meaningful exception when an undefined user provider is used inside a firewall #24114

Conversation

chalasr commented Sep 6, 2017 • edited Loading

nicolas-grekas Sep 7, 2017

Choose a reason for hiding this comment

chalasr Sep 7, 2017

Choose a reason for hiding this comment

nicolas-grekas Sep 7, 2017

Choose a reason for hiding this comment

fabpot commented Sep 7, 2017

mvrhov commented Sep 7, 2017

mvrhov commented Sep 7, 2017 • edited Loading

mvrhov commented Sep 7, 2017

chalasr commented Sep 7, 2017

chalasr commented Sep 7, 2017

chalasr commented Sep 6, 2017 •

edited

Loading

mvrhov commented Sep 7, 2017 •

edited

Loading