[Form] Hide label button when its setted to false #24148
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added same behaviour in buttons like in other form components when label is setted to false, don't show it. It's very useful with buttons with icon and without text
|
That's a new behavior, so merging it into 3.4 instead. |
fabpot
approved these changes
Sep 30, 2017
|
Thank you @TeLiXj. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2017
…iXj) This PR was submitted for the 2.7 branch but it was merged into the 3.4 branch instead (closes #24148). Discussion ---------- [Form] Hide label button when its setted to false | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | Added same behaviour in buttons like in other form components when label is setted to false, don't show it. It's very useful with buttons with icon and without text. Commits ------- e319075 Hide label button when its setted to false
This was referenced Oct 18, 2017
Merged
Merged
fabpot
pushed a commit
that referenced
this pull request
Jan 17, 2018
Improve my previous contribution to hide button label when it's set to false (#24148) because a missing translation error appear
fabpot
added a commit
that referenced
this pull request
Jan 17, 2018
…se (TeLiXj) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #25249). Discussion ---------- [Form] Avoid button label translation when it's set to false | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | | License | MIT | Doc PR | Improve my previous contribution to hide button label when it's set to false (#24148) because a missing translation error appears Commits ------- 368edd8 Avoid button label translation when it's set to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added same behaviour in buttons like in other form components when label is setted to false, don't show it.
It's very useful with buttons with icon and without text.