[Translation] drop MessageSelector support in the Translator #24176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Sep 12, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
|
The failure seems to be related to a commit hash that was not propagated from the subtree split of the Translation component to packagist.org. |
|
I've updated Packagist, is it better now? |
a5da486 to
2028a83
Compare
|
finally, Travis CI got that change too |
fabpot
approved these changes
Sep 13, 2017
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Sep 13, 2017
…slator (xabbuh) This PR was merged into the 4.0-dev branch. Discussion ---------- [Translation] drop MessageSelector support in the Translator | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 2028a83 drop MessageSelector support in the Translator
Merged
|
@flip111 not sure what you mean, this PR is precisely tagged as a BC break because we removed things that were deprecated before |
|
Yes that's fine, i'm just making a comment as cross-reference ... |
|
Please abstain from doing so. This just causes unnecessary noise for everyone having subscribed to the Symfony repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.