[FrameworkBundle] Add support to environment variables APP_ENV/DEBUG in KernelTestCase #24177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess fabbot failure (unrelated) should be fixed from |
xabbuh
reviewed
Sep 12, 2017
| ); | ||
| if (isset($options['environment'])) { | ||
| $env = $options['environment']; | ||
| } elseif (isset($_SERVER['APP_ENV']) || isset($_ENV['APP_ENV'])) { |
There was a problem hiding this comment.
I think I would split this in two:
if (isset($options['environment'])) {
$env = $options['environment'];
} elseif (isset($_SERVER['APP_ENV'])) {
$env = $_SERVER['APP_ENV'];
} elseif (isset($_ENV['APP_ENV'])) {
$env = $_ENV['APP_ENV'];
} else {
$env = 'test';
}|
Should we merge this one as a bugfix into the |
31d01c4 to
4e58195
Compare
|
As a bugfix should be into |
|
As env vars are "officially" supported since 3.3, I'd vote for a merge in 3.3 |
fabpot
approved these changes
Sep 12, 2017
4e58195 to
8d56744
Compare
|
Done. |
xabbuh
approved these changes
Sep 13, 2017
|
Thank you @yceruto. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 13, 2017
…_ENV/DEBUG in KernelTestCase (yceruto) This PR was merged into the 3.3 branch. Discussion ---------- [FrameworkBundle] Add support to environment variables APP_ENV/DEBUG in KernelTestCase | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/recipes#170 (comment) | License | MIT | Doc PR | - /cc @fabpot Commits ------- 8d56744 Add support to environment variables APP_ENV/DEBUG in KernelTestCase
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @fabpot