Skip to content

Added an alias for FlashBagInterface in config #24200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Added an alias for FlashBagInterface in config #24200

wants to merge 1 commit into from

Conversation

tifabien
Copy link
Contributor

Q A
Branch? 3.3
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Sep 16, 2017
nicolas-grekas
nicolas-grekas approved these changes Sep 16, 2017
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for 3.4 as a new feature to me

@fabpot
Copy link
Member

fabpot commented Sep 16, 2017

Somewhat related: #11279 and co

@chalasr
Copy link
Member

chalasr commented Sep 17, 2017 •
edited
Loading

Regarding #11279, would it make sense to make this service available in AbstractController? (could be for another PR)

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Sep 18, 2017 •
edited
Loading

@chalasr in practice a Session instance is always provided. With this alias ppl could at least type-hint a controller/action argument. Isn't it enough?

@chalasr
Copy link
Member

chalasr commented Sep 19, 2017

Indeed!

xabbuh
xabbuh approved these changes Sep 19, 2017
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a feature in 3.4

@tifabien
Copy link
Contributor Author

Do I need to rebase my branch on top of 3.4 or is it not necessary?

@nicolas-grekas
Copy link
Member

Thank you @tifabien.

nicolas-grekas added a commit that referenced this pull request Sep 26, 2017
@nicolas-grekas
feature #24200 Added an alias for FlashBagInterface in config (tifabien)
7f2bfc0 
This PR was submitted for the 3.3 branch but it was merged into the 3.4 branch instead (closes #24200).

Discussion
----------

Added an alias for FlashBagInterface in config

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

b6b6d31 Added an alias for FlashBagInterface in config
@tifabien tifabien deleted the add-flash-bag-alias branch September 28, 2017 11:00
This was referenced Oct 18, 2017
Merged
Merged
@Tobion Tobion mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@xabbuh xabbuh xabbuh approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
6 participants
@tifabien @fabpot @chalasr @nicolas-grekas @xabbuh @carsonbot