[Serializer] Add local cache to normalizers #24228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Sep 15, 2017
ro0NL
reviewed
Sep 15, 2017
|
|
||
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function supportsNormalization($data, $format = null) | ||
| { | ||
| return parent::supportsNormalization($data, $format) && $this->supports(get_class($data)); | ||
| return parent::supportsNormalization($data, $format) && (isset($this->cache[$type = \get_class($data)]) ? $this->cache[$type] : $this->cache[$type] = $this->supports($type)); |
There was a problem hiding this comment.
applies to supportsDenormalization as well, no?
There was a problem hiding this comment.
what about private static $cache + private static supports() + inline isGetMethod
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function supportsNormalization($data, $format = null) | ||
| { | ||
| return parent::supportsNormalization($data, $format) && $this->supports(get_class($data)); | ||
| return parent::supportsNormalization($data, $format) && (isset($this->cache[$type = \get_class($data)]) ? $this->cache[$type] : $this->cache[$type] = $this->supports($type)); |
6e94152 to
44dd0ad
Compare
Done. |
44dd0ad to
a0fe606
Compare
nicolas-grekas
commented
Sep 16, 2017
| @@ -66,7 +66,7 @@ public function denormalize($data, $class, $format = null, array $context = arra | |||
| */ | |||
| public function supportsDenormalization($data, $type, $format = null/*, array $context = array()*/) | |||
| { | |||
| $context = func_num_args() > 3 ? func_get_arg(3) : array(); | |||
| $context = \func_num_args() > 3 ? func_get_arg(3) : array(); | |||
There was a problem hiding this comment.
0fdab2f to
23f485e
Compare
ro0NL
approved these changes
Sep 16, 2017
ogizanagi
approved these changes
Sep 16, 2017
23f485e to
b0c5cf0
Compare
|
Won't it make sense to backport what could be on lower branches? |
AFAIK, we merge perf improvements as new feats usually (even if we diverged sometime from this rule, but we shouldn't anymore unless catastrophic. Not sure it's the case here?) |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 20, 2017
…kas) This PR was merged into the 3.4 branch. Discussion ---------- [Serializer] Add local cache to normalizers | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24206 | License | MIT | Doc PR | - Should help making the Serializer a bit faster. Commits ------- b0c5cf0 [Serializer] Add local cache to normalizers
nicolas-grekas
added a commit
to nicolas-grekas/symfony
that referenced
this pull request
Oct 1, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help making the Serializer a bit faster.