[DI] Fix private-by-default BC layer #24266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f6b1009 to
ff2ab58
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Sep 19, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DI] Fix private-by-default BC layer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24238 | License | MIT | Doc PR | - Spotted while merging 3.4 into master and by looking at the cross-versions CI. Commits ------- ff2ab58 [DI] Fix private-by-default BC layer
nicolas-grekas
commented
Sep 19, 2017
| @trigger_error(sprintf('Fetching the "%s" private service is deprecated and will fail in Symfony 4.0. Make the service public instead.', $id), E_USER_DEPRECATED); | ||
| } | ||
| if (isset($this->aliasDefinitions[$id]) && $this->aliasDefinitions[$id]->isPrivate()) { | ||
| @trigger_error(sprintf('Fetching the "%s" private alias is deprecated and will fail in Symfony 4.0. Make the alias public instead.', $id), E_USER_DEPRECATED); |
There was a problem hiding this comment.
these deprecation are required because in master, these services/aliases are removed by the RemoveUnusedServicesPass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotted while merging 3.4 into master and by looking at the cross-versions CI.