[Serializer] Getter for extra attributes in ExtraAttributesException #24277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogizanagi
reviewed
Sep 21, 2017
| * {@inheritdoc} | ||
| * | ||
| * @param array $extraAttributes Extra attributes that are not allowed | ||
| * @param \Exception $previous Previous exception |
There was a problem hiding this comment.
This docblock isn't much useful, so it can be reverted.
| /** | ||
| * Extra attributes. | ||
| * | ||
| * @var array |
There was a problem hiding this comment.
Same. The constructor already typehints the $extraAttributes argument, and the name is self explanatory :)
ogizanagi
approved these changes
Sep 22, 2017
xabbuh
approved these changes
Sep 22, 2017
stof
approved these changes
Sep 22, 2017
|
Thank you @mdeboer. |
ogizanagi
added a commit
that referenced
this pull request
Sep 22, 2017
…butesException (mdeboer) This PR was squashed before being merged into the 3.4 branch (closes #24277). Discussion ---------- [Serializer] Getter for extra attributes in ExtraAttributesException | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes (failure unrelated) | Fixed tickets | | License | MIT This PR adds a public getter for the extra attributes in `ExtraAttributesException` and makes it easier to create custom exception messages (e.g. JSON formatted). Commits ------- cb935e7 [Serializer] Getter for extra attributes in ExtraAttributesException
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a public getter for the extra attributes in
ExtraAttributesExceptionand makes it easier to create custom exception messages (e.g. JSON formatted).