Skip to content

Removed unused private property in the ContextListener #24329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Removed unused private property in the ContextListener #24329

merged 1 commit into from
Sep 26, 2017

Conversation

linaori
Copy link
Contributor

@linaori linaori commented Sep 26, 2017

Q A
Branch? 2.7
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #23882 (comment)
License MIT
Doc PR ~

The context property is unused, the local variable (constructor argument) is only concatenated to a string inside (session key).

@nicolas-grekas nicolas-grekas added this to the 2.7 milestone Sep 26, 2017
@nicolas-grekas
Copy link
Member

Thank you @iltar.

@nicolas-grekas nicolas-grekas merged commit 6522c05 into symfony:2.7 Sep 26, 2017
nicolas-grekas added a commit that referenced this pull request Sep 26, 2017
…iltar)

This PR was merged into the 2.7 branch.

Discussion
----------

Removed unused private property in the ContextListener

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23882 (comment)
| License       | MIT
| Doc PR        | ~

The context property is unused, the local variable (constructor argument) is only concatenated to a string inside (session key).

Commits
-------

6522c05 Removed unused private property
@linaori linaori deleted the fix/unused-context-key branch February 8, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants