[HttpFoundation] Removed compatibility layer for PHP <5.4 sessions #24338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
875696b to
241566f
Compare
Tobion
reviewed
Sep 26, 2017
| @@ -47,9 +47,8 @@ public function testEnvironment() | |||
|
|
|||
| public function testGetSession() | |||
| { | |||
| $session = $this->getMockBuilder(Session::class)->disableOriginalConstructor()->getMock(); | |||
There was a problem hiding this comment.
Because of the fact that the session is constructed using an instance of NativeSessionStorage that by default used the deprecated SessionHandlerProxy, this test did not pass due to the deprecation error. Now there are no deprecations, so no need for disabling the original constructor,
There was a problem hiding this comment.
We should be using MockArraySessionStorage rather than NativeSessionStorage in tests (or create a mock as before).
Tobion
approved these changes
Sep 26, 2017
chalasr
approved these changes
Sep 26, 2017
Signed-off-by: Alexandru Furculita <alex@furculita.net>
241566f to
37d1a21
Compare
|
Changelog updated |
stof
approved these changes
Sep 27, 2017
|
AppVeyor failure not related to this PR |
|
Thank you @afurculita. |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2017
…5.4 sessions (afurculita) This PR was merged into the 4.0-dev branch. Discussion ---------- [HttpFoundation] Removed compatibility layer for PHP <5.4 sessions | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This is a follow-up of #24239. This PR removes the compatibility layer added for sessions for PHP <5.4. Commits ------- 37d1a21 Removed compatibility layer for PHP <5.4 sessions
xabbuh
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 13, 2017
This PR was merged into the master branch. Discussion ---------- Update outdated session documentation with SF 4 The PHP 5.3 compatibilty and proxy logic has been removed in symfony/symfony#24338 The MemcacheSessionHandler is removed with symfony/symfony#24447 Commits ------- bd765c1 Update outdated session documentation with SF 4
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #24239. This PR removes the compatibility layer added for sessions for PHP <5.4.