removed useless PHPDoc #24342
Closed
removed useless PHPDoc #24342
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OskarStark
commented
Sep 27, 2017
•
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | n/a |
lyrixx
approved these changes
Sep 27, 2017
|
there are a lot more, shall I remove them, too? https://github.com/symfony/symfony/search?o=asc&q=%2A+Constructor.&s=indexed&type=&utf8=%E2%9C%93 |
|
Yes please |
|
It should start by targeting the lowest maintained branch (i.e 2.7), not 3.3. :) |
can you do this or shall I switch the branch? |
|
You should do it since it will lead to a rebase |
done @ogizanagi |
ogizanagi
approved these changes
Sep 28, 2017
|
@OskarStark: There are still some tests failing. |
fabbot is failing, but not related to this PR |
|
can you still fix fabbot failure please? |
done @nicolas-grekas 👍 |
xabbuh
approved these changes
Sep 28, 2017
|
Hmm, I don't know why they are failing... 😢 |
nicolas-grekas
approved these changes
Sep 28, 2017
good to know, thank you @nicolas-grekas |
stof
approved these changes
Sep 28, 2017
fabpot
added a commit
that referenced
this pull request
Sep 30, 2017
This PR was squashed before being merged into the 2.7 branch (closes #24342). Discussion ---------- removed useless PHPDoc | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | n/a Commits ------- 5ee9043 removed useless PHPDoc
fabpot
added a commit
that referenced
this pull request
Oct 4, 2017
This PR was merged into the 3.4 branch. Discussion ---------- [DI] remove inheritdoc from dumped container | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The inheritdoc without adding text is pointless on it's own as any decent IDE will show that those methods are overwriting the base method. This removes it from the dumped container to remove memory and generation time. This goes in the same direction as #23673, #18048 and #24342 It does not affect phpdocs of the compiled container that might actually be useful (factory methods of services explaining if the service is private, shared etc.). Commits ------- d779845 [DI] remove inheritdoc from dumped container
ostrolucky
pushed a commit
to ostrolucky/symfony
that referenced
this pull request
Mar 25, 2018
This PR was squashed before being merged into the 2.7 branch (closes symfony#24342). Discussion ---------- removed useless PHPDoc | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | n/a Commits ------- 5ee9043 removed useless PHPDoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.