[HttpKernel] Deprecate some compiler passes in favor of tagged iterator args #24362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when merging into master, "symfony/dependency-injection" should be removed from Config's composer.json |
a75ae94 to
98ef323
Compare
chalasr
reviewed
Sep 28, 2017
| */ | ||
| public function add(CacheClearerInterface $clearer) | ||
| { | ||
| @trigger_error(sprintf('The "%s()" method is deprecated since version 3.4 and will be removed in 4.0, inject the list of clearers as a constructor argument instead.', __METHOD__), E_USER_DEPRECATED); | ||
|
|
||
| $this->clearers[] = $clearer; |
There was a problem hiding this comment.
isn't$this->clearers an iterator now?
There was a problem hiding this comment.
Is it, but here is my reasoning: this method is deprecated, and no code exists yet that uses both the method and an iterator. No new code should be written that would use both an iterator, and the deprecated method. Thus, all is fine :)
98ef323 to
fa62e50
Compare
fabpot
approved these changes
Sep 28, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Sep 28, 2017
…f tagged iterator args (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpKernel] Deprecate some compiler passes in favor of tagged iterator args | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - More code that we can drop :) Commits ------- fa62e50 [HttpKernel] Deprecate some compiler passes in favor of tagged iterator args
|
Ref PR introducing this feature: #22200 |
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More code that we can drop :)