[SecurityBundle] Deprecate auto picking the first provider #24378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Sep 30, 2017
| @@ -358,6 +358,10 @@ private function createFirewall(ContainerBuilder $container, $id, $firewall, &$a | |||
| } | |||
| $defaultProvider = $providerIds[$normalizedName]; | |||
| } else { | |||
| if (count($providerIds) > 1) { | |||
| @trigger_error(sprintf('Not configuring explicitly the provider on "%s" firewall is ambiguous as there is more than one registered provider. Using the first configured provider is deprecated since 3.4 and it will throw an exception on 4.0 instead.', $id), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
I suggest
Firewall "$id" has no "provider" set but multiple providers exist. Using the first configured provider ($defaultProvider) is deprecated since 3.4 and will throw an exception in 4.0, set the "provider" key on the firewall instead.
There was a problem hiding this comment.
Perfect, thanks 👍
when no provider is explicitly configured on a firewall
javiereguiluz
approved these changes
Sep 30, 2017
fabpot
approved these changes
Sep 30, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Sep 30, 2017
…ider (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [SecurityBundle] Deprecate auto picking the first provider when no provider is explicitly configured on a firewall | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | yes <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | https://symfony-devs.slack.com/archives/C3A2XAQ20/p1506626210000345 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A From @Pierstoval on Slack: > Hey, guys, I learnt a few days ago that if you don't specify a user provider in a firewall configuration, the security will use the first one in the list. Don't anyone think specifying the user provider should be mandatory ? Or at least mandatory if we have more than one provider registered? - [x] UPGRADE files - [x] CHANGELOG - [x] Fix other tests - [x] Removal PR #24380 Commits ------- 2d1e334 [SecurityBundle] Deprecate auto picking the first provider
fabpot
added a commit
that referenced
this pull request
Sep 30, 2017
…r (ogizanagi) This PR was merged into the 4.0-dev branch. Discussion ---------- [SecurityBundle] Remove auto picking the first provider when no provider is explicitly configured on a firewall | Q | A | ------------- | --- | Branch? | master <!-- see comment below --> | Bug fix? | no | New feature? | yes <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24378 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A After #24378 Commits ------- aeb57ab [SecurityBundle] Remove auto picking the first provider
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when no provider is explicitly configured on a firewall
From @Pierstoval on Slack: