[FrameworkBundle] Don't clear app pools on cache:clear #24383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
776cf30 to
6fe698f
Compare
6fe698f to
45b5b93
Compare
Tobion
approved these changes
Sep 29, 2017
ogizanagi
approved these changes
Sep 30, 2017
|
Tests are failing |
45b5b93 to
b0c04f8
Compare
|
Tests fixed. |
chalasr
approved these changes
Sep 30, 2017
fabpot
approved these changes
Oct 1, 2017
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 1, 2017
… (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Don't clear app pools on cache:clear | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no, but behavior change | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23685 | License | MIT | Doc PR | - The cache:clear command currently clears all cache pools by default. This is not expected and is a bad default behavior (as explained in linked issue). If we don't want to have that behavior forever, I see no other option than just doing the change, as done here, targeting 3.4. Commits ------- b0c04f8 [FrameworkBundle] Don't clear app pools on cache:clear
This was referenced Oct 18, 2017
Merged
Merged
|
To clarify, the default |
|
not anymore on 3.4 |
|
hmm, I'm still seeing it cleared on BETA3. I figured this was expected because isn't the entire cache dir wiped on |
|
Indeed, that's the reason. You'd need to store items elsewhere. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cache:clear command currently clears all cache pools by default.
This is not expected and is a bad default behavior (as explained in linked issue).
If we don't want to have that behavior forever, I see no other option than just doing the change, as done here, targeting 3.4.