-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Remove the array long syntax requirement #24396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I like the idea but I don't like the implementation. If merged, this will make the code use sometimes |
👎 |
Following the conversation in #22862, everybody kind of agreed that we should use PHP7+ syntaxes for all new code bases. @nicolas-grekas I think your point is valid: cases where PRs are just updating existing usage of |
This won't work in practice. Non-regular contributors don't read the guidelines and don't follow them. This would cause lots of problems. |
@javiereguiluz but we can't "make this change at once in the entire codebase" until 2018 because 2.7/2.8 have PHP 5.3 (that do not have the short-array syntax) as minimum PHP version. |
correct, let's discuss this again in one year. |
Closing for now as explained. |
👍 |
Remove the long-array-syntax rule in the PHP-CS rules to allow usage of short-syntax PHP array for new PRs going to 4.1.