[DI] Remove AutowireExceptionPass #24398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ogizanagi
commented
Oct 2, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24290 |
| License | MIT |
| Doc PR | N/A |
| { | ||
| @trigger_error('Calling AutowirePass::getAutowiringExceptions() is deprecated since Symfony 3.4 and will be removed in 4.0. Use Definition::getErrors() instead.', E_USER_DEPRECATED); | ||
|
|
||
| return $this->autowiringExceptions; |
There was a problem hiding this comment.
the property should be removed also (same in the other pass)
nicolas-grekas
approved these changes
Oct 2, 2017
stof
reviewed
Oct 2, 2017
| @@ -22,6 +22,7 @@ CHANGELOG | |||
| * removed support for setting and accessing private services in `Container` | |||
| * removed support for setting pre-defined services in `Container` | |||
| * removed support for case insensitivity of parameter names | |||
| * removed `AutowireExceptionPass` and `AutowirePass::getAutowiringExceptions()`, use `Definition::addError()` and the `DefinitionErrorExceptionPass` instead | |||
There was a problem hiding this comment.
Not having anything in the 3.4 changelog about the deprecation looks weird to me. The changelog should be updated (in a separate branch)
|
can be rebased now that #24399 is merged. |
dunglas
approved these changes
Oct 2, 2017
|
Rebased |
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2017
This PR was merged into the 4.0-dev branch. Discussion ---------- [DI] Remove AutowireExceptionPass | Q | A | ------------- | --- | Branch? | master <!-- see comment below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | yes | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24290 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Commits ------- 2ada558 [DI] Remove AutowireExceptionPass
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.