[FrameworkBundle][Routing] Show welcome message if no routes are configured #24403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures:
|
yceruto
commented
Oct 2, 2017
src/Symfony/Bundle/FrameworkBundle/EventListener/NoRoutingConfigurationSubscriber.php
Outdated
Show resolved
Hide resolved
fabpot
requested changes
Oct 2, 2017
src/Symfony/Bundle/FrameworkBundle/EventListener/NoRoutingConfigurationSubscriber.php
Outdated
Show resolved
Hide resolved
| $code .= " if ('/' === \$pathinfo) {\n"; | ||
| $code .= " throw new Symfony\Component\Routing\Exception\NoConfigurationException();\n"; | ||
| $code .= " }\n"; | ||
| } |
There was a problem hiding this comment.
I like this approach, makes a lot of sense to me.
yceruto
commented
Oct 2, 2017
src/Symfony/Component/HttpKernel/EventListener/RouterListener.php
Outdated
Show resolved
Hide resolved
|
Status: Needs Review |
|
Now the solution looks better to me, so the response is setting on |
yceruto
commented
Oct 2, 2017
src/Symfony/Component/HttpKernel/EventListener/RouterListener.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/EventListener/RouterListener.php
Outdated
Show resolved
Hide resolved
a2670cc to
d83b578
Compare
|
@yceruto Can you also patch the other URL matchers like |
|
@fabpot indeed, thanks. |
|
@yceruto I think we need support for the new exception in |
|
@fabpot done. |
fabpot
requested changes
Oct 2, 2017
fabpot
approved these changes
Oct 2, 2017
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 2, 2017
…routes are configured (yceruto) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][Routing] Show welcome message if no routes are configured | Q | A | ------------- | --- | Branch? | 3.4 (it would be good, else 4.1) | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/flex#20 | License | MIT | Doc PR | - Another attempt to improve the first time experience with a different technical approach this time. Just after a fresh "SymfonyFlex" installation: ```bash $ composer create-project symfony/skeleton flex $ cd flex $ make serve ```  When the first route is added, this message is no longer displayed (same if debug mode is disabled). ping @javiereguiluz, @sstok Commits ------- e097ab3 Show welcome message if no routing configuration could be found
This was referenced Oct 18, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to improve the first time experience with a different technical approach this time.
Just after a fresh "SymfonyFlex" installation:
$ composer create-project symfony/skeleton flex $ cd flex $ make serveWhen the first route is added, this message is no longer displayed (same if debug mode is disabled).
ping @javiereguiluz, @sstok