storage session pdo for postgres fix #24457
Conversation
| @@ -395,7 +395,7 @@ public function close() | |||
| $this->gcCalled = false; | |||
|
|
|||
| // delete the session records that have expired | |||
| $sql = "DELETE FROM $this->table WHERE $this->lifetimeCol + $this->timeCol < :time"; | |||
| $sql = "DELETE FROM $this->table WHERE $this->lifetimeCol < :time - $this->timeCol"; | |||
There was a problem hiding this comment.
isn't is the same?
a + b < c === a < c - b
There was a problem hiding this comment.
no, in postgres
a and b - integer type (32 bit)
a+b > integer (2^32/2) - it's error
a-b <= integer and accepted by postgres
There was a problem hiding this comment.
this problem in postgres only
There was a problem hiding this comment.
is it possible to use unsigned types? or larger types e.g. long (64 bits instead of 32)
There was a problem hiding this comment.
Creating tables is in the same package. But to increase the amount of data due to improper use is incorrect
There was a problem hiding this comment.
Moreover, the sessional table contains a lot of records, and the losses will be large
| @@ -1,6 +1,9 @@ | |||
| CHANGELOG | |||
| ========= | |||
|
|
|||
| * PdoSessionHandler changes | |||
| - bugfix timestamp integer out of range in Postgres | |||
There was a problem hiding this comment.
this should be removed, we dont alter this file for bug fixes
|
tests red for old version of symfony((( |
|
Symfony 2.6 is not maintained anymore. Should be rebaed against 2.7 |
|
please review this pull request, rebase from 2.6 to 2.7 to long time... |
This PR was merged into the 2.7 branch. Discussion ---------- pdo session fix | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24456 | License | MIT | Doc PR | Fix PDO session timestamp out of range for postgres. (branch from 2.7) P.S. please delete this pull #24457 Commits ------- 56b29a7 pdo session fix
This PR was merged into the 2.7 branch. Discussion ---------- pdo session fix | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24456 | License | MIT | Doc PR | Fix PDO session timestamp out of range for postgres. (branch from 2.7) P.S. please delete this pull symfony/symfony#24457 Commits ------- 56b29a754c pdo session fix
Fixed issue, this error in 2.6+ versions