[Form] fix intl related failures #24471
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Oct 7, 2017
| Q | A |
|---|---|
| Branch? | 2.8 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19854, #22586, #24460 (comment) |
| License | MIT |
| Doc PR |
| @@ -144,6 +144,7 @@ public function testDecimalSeparatorMayNotBeDotIfGroupingSeparatorIsDot() | |||
| // Since we test against "de_AT", we need the full implementation | |||
| IntlTestHelper::requireFullIntl($this, '4.8.1.1'); | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
an extra line here fixes the issue? would it work if the line were a comment instead?
There was a problem hiding this comment.
Nope, I just wanted to find out on which branch the AppVeyor build started to fall. Because of the linked PR I thought it should have been this branch. Turns out it wasn't.
There was a problem hiding this comment.
However, merging #24460 into the 2.7 branch and merge it from there should fully resolve the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.