Fix PHP 7.2 tests on master branch #24515
Conversation
nicolas-grekas
commented
Oct 11, 2017
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | not yet |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| - php: 7.1.3 | ||
| - php: 7.1 | ||
| env: deps=high | ||
| - php: 7.1 |
There was a problem hiding this comment.
this is meant to be reverted, right ?
There was a problem hiding this comment.
yes, just for testing now
|
Looks weird to have @Simperfit and @sroze approving the PR at a time it is totally not mergeable... |
|
On 7.2:
If someone wants to investigate, help welcomed :) |
|
@nicolas-grekas Did you merge the one we did back to master ? it's the same thing |
|
Yes I did, so this is some leftover. |
|
Both the ini's one should not be hard to fix (I think it's the same error as the other PR). About the Process components that hang, I could help you debugging if you want to. @stof I approuved this PR because I though (maybe, too fast) that this will be working directly since we already worked on it. Sorry. |
|
@Simperfit removing testing on PHP 7.1 cannot be approved as is anyway. |
|
@nicolas-grekas Interestingly I see it the other way around:
|
|
If it hangs locally with HttpFoundation, it may be related to an obsolete phpunit bridge. Try removing the |
|
Doesn't seam like it, I've |
|
Looks like all the tests tagged |
|
|
This PR was squashed before being merged into the 4.0-dev branch (closes #24516). Discussion ---------- [Process] Fix broken tests for PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #24524, #24515 | License | MIT | Doc PR | ø Following #24515, trying to fix Process tests with PHP 7.2 Commits ------- b410a36 [Process] Fix broken tests for PHP 7.2