[Process] Fix broken tests for PHP 7.2 #24516
Conversation
|
Status: needs work |
.travis.yml
Outdated
| env: deps=high | ||
| - php: 7.1 | ||
| env: deps=low | ||
| - php: 7.2 |
There was a problem hiding this comment.
can you add another line:
- php: 7.2
- php: 7.2
env: deps=low
5be2f4c to
1677777
Compare
|
you should avoid it being marked as an intermediary version though. You don't want it to be skipped. |
c891a90 to
b48b20a
Compare
|
@stof do you think we should prevent 7.2 to be marked as intermediate for all the PRs or it was just in the context of my debugging? |
|
Status: Needs Review |
|
|
||
| if (\PHP_SESSION_ACTIVE === session_status()) { | ||
| if (!empty($options) || null !== $handler) { | ||
| throw new \LogicException('Cannot change options or handler of an active session'); |
There was a problem hiding this comment.
Do we really to throw here ? maybe a test should be added to test this behaviour ?
|
|
||
| matrix: | ||
| include: | ||
| - php: 7.1.3 | ||
| - php: 7.1 | ||
| env: deps=high | ||
| - php: 7.1 | ||
| - php: 7.2 |
There was a problem hiding this comment.
maybe we could add without deps=low too
There was a problem hiding this comment.
nope: the matrix is optimized to test the maximum of cases with the minimum number of jobs
|
@nicolas-grekas as discussed, kept here only the process test change and travis configuration and moved the native session storage PR to #24531 to target 2.7. |
04164e2 to
f764735
Compare
|
And rebased. Tests are logically still failing because of the HttpFoundation bug fixed in #24531. |
f764735 to
dd39cb5
Compare
|
Rebased and now 💚. /cc @xabbuh |
|
Thank you @sroze. |
This PR was squashed before being merged into the 4.0-dev branch (closes #24516). Discussion ---------- [Process] Fix broken tests for PHP 7.2 | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | #24524, #24515 | License | MIT | Doc PR | ø Following #24515, trying to fix Process tests with PHP 7.2 Commits ------- b410a36 [Process] Fix broken tests for PHP 7.2
Following #24515, trying to fix Process tests with PHP 7.2