[Validator] [Twig] added magic method __isset() to File Constraint class #24519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase and retarget your PR for 3.4? (+ update the CHANGELOG) |
nicolas-grekas
approved these changes
Oct 12, 2017
fabpot
approved these changes
Oct 12, 2017
|
Sounds like a bug to me though. |
|
Thank you @loru88. |
fabpot
added a commit
that referenced
this pull request
Oct 12, 2017
…nstraint class (loru88) This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #24519). Discussion ---------- [Validator] [Twig] added magic method __isset() to File Constraint class | Q | A | ------------- | --- | Branch? | 3.4 or master / 2.7, 2.8 or 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | yes <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24512 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> In my project I get assert constraints from one of my entity and I use this value in my front end via Twig. I faced a problem with the property $maxSize of the File Constraint. As this property is protected I cannot access it via Twig because the magic method __isset is missing, as I read in twig documentation. <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- 9efb765 [Validator] added magic method __isset() to File Constraint class
|
merged into 2.7. |
|
your 're welcome @fabpot, sorry to not have merged into 2.7 |
This was referenced Nov 10, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project I get assert constraints from one of my entity and I use this value in my front end via Twig.
I faced a problem with the property $maxSize of the File Constraint.
As this property is protected I cannot access it via Twig because the magic method __isset is missing, as I read in twig documentation.