[BrowserKit][Bridge\PhpUnit] Handle deprecations triggered in separate processes #24548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we fix the location that is reported (it's always |
|
@xabbuh cross-process stack trace communication, not trivial to implement. |
xabbuh
approved these changes
Oct 13, 2017
fabpot
approved these changes
Oct 13, 2017
a0d4009 to
ca0fedd
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 13, 2017
… processes (paul-m) This PR was merged into the 3.3 branch. Discussion ---------- [Bridge\PhpUnit] Handle deprecations triggered in separate processes | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23003, #16726 | License | MIT | Doc PR | - As reported in #23003, deprecations triggered in process-isolated test cases are not gathered. This caught us already: HttpFoundation is still using deprecated code paths, but we missed them because of that issue with the bridge. Here is the fixed output:  Credits to @paul-m for working on the issue first. Commits ------- ca0fedd [BrowserKit] Handle deprecations triggered in insulated requests ff379ef [Bridge\PhpUnit] Handle deprecations triggered in separate processes
|
FYI, fixes also BrowserKit: |
|
Thank you @fabpot and @nicolas-grekas! |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2017
…(xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] fix deprecation triggering test detection | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24548 (comment), #24568 | License | MIT | Doc PR | Commits ------- da617e8 fix deprecation triggering test detection
symfony-splitter
pushed a commit
to symfony/phpunit-bridge
that referenced
this pull request
Oct 24, 2017
…(xabbuh) This PR was merged into the 3.3 branch. Discussion ---------- [PhpUnitBridge] fix deprecation triggering test detection | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#24548 (comment), #24568 | License | MIT | Doc PR | Commits ------- da617e8 fix deprecation triggering test detection
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #23003, deprecations triggered in process-isolated test cases are not gathered.
This caught us already: HttpFoundation is still using deprecated code paths, but we missed them because of that issue with the bridge.
Here is the fixed output:
Credits to @paul-m for working on the issue first.