[Serializer] YamlEncoder: throw if the Yaml component isn't installed #24565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Oct 16, 2017
derrabus
approved these changes
Oct 16, 2017
xabbuh
reviewed
Oct 16, 2017
| @@ -29,6 +30,10 @@ class YamlEncoder implements EncoderInterface, DecoderInterface | |||
|
|
|||
| public function __construct(Dumper $dumper = null, Parser $parser = null, array $defaultContext = array()) | |||
| { | |||
| if (!class_exists(Dumper::class)) { | |||
| throw new RuntimeException('Unable to use YamlEncoder as the Symfony Yaml component is not installed.'); | |||
There was a problem hiding this comment.
Maybe we should add the package name here too as suggested in #24563.
weaverryan
approved these changes
Oct 16, 2017
fabpot
approved these changes
Oct 16, 2017
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2017
…t installed (dunglas) This PR was squashed before being merged into the 3.3 branch (closes #24565). Discussion ---------- [Serializer] YamlEncoder: throw if the Yaml component isn't installed | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | no | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | n/a Similar to #24563 but for the Yaml encoder (not the same branch). Commits ------- 7d21caf [Serializer] YamlEncoder: throw if the Yaml component isn't installed
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #24563 but for the Yaml encoder (not the same branch).