[PropertyInfo] Add support for the iterable type #24571
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simperfit
approved these changes
Oct 16, 2017
Toflar
reviewed
Oct 16, 2017
| @@ -43,6 +44,7 @@ class Type | |||
| self::BUILTIN_TYPE_ARRAY, | |||
| self::BUILTIN_TYPE_CALLABLE, | |||
| self::BUILTIN_TYPE_NULL, | |||
| self::BUILTIN_TYPE_ITERABLE, | |||
There was a problem hiding this comment.
phpdoc of getBuiltinType() should be updated too :)
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Oct 16, 2017
This PR was squashed before being merged into the 2.8 branch (closes #24571). Discussion ---------- [PropertyInfo] Add support for the iterable type | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | reported on Slack | License | MIT | Doc PR | n/a Add support for the `iterable` pseudo-type introduced in PHP 7.1. Commits ------- a73249d [PropertyInfo] Add support for the iterable type
This was referenced Oct 30, 2017
Merged
Merged
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Apr 16, 2018
…ted (fmata) This PR was merged into the 2.8 branch. Discussion ---------- [PropertyInfo] Complete the list of built-in types supported symfony/symfony#24571 introduced `iterable` type but the doc has not been updated. Commits ------- 8097eb9 Update property_info.rst
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 11, 2018
…s initializable (dunglas, javiereguiluz) This PR was merged into the master branch. Discussion ---------- [PropertyInfo] Add an extractor to guess if a property is initializable symfony/symfony#26997 symfony/symfony#24571 Closes #10272. Commits ------- 8415f96 Minor tweaks eebca4a RST f7ed144 [PropertyInfo] Add an extractor to guess if a property is initializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the
iterablepseudo-type introduced in PHP 7.1.