Prefer line formatter on missing cli dumper #24598
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The console formatter does a better job, unless the VarDumper component is missing, in which case you will not see the "context" or "extra" keys and the LineFormatter should be preferred.
greg0ire
commented
Oct 17, 2017
| @@ -162,6 +164,9 @@ protected function write(array $record) | |||
| */ | |||
| protected function getDefaultFormatter() | |||
| { | |||
| if (!class_exists(CliDumper::class)) { | |||
There was a problem hiding this comment.
I did not find a way to test this (other than change the namespace of the test to match the one of the class but I'm don't think that would be ok with you).
nicolas-grekas
approved these changes
Oct 18, 2017
|
Can anyone fix the labels? |
chalasr
approved these changes
Oct 18, 2017
|
Thank you @greg0ire. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Prefer line formatter on missing cli dumper | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none, but closes symfony/recipes#145 | License | MIT | Doc PR | n/a The console formatter does a better job, unless the VarDumper component is missing, in which case the LineFormatter should be preferred. Commits ------- 574f9f5 Prefer line formatter on missing cli dumper
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The console formatter does a better job, unless the VarDumper component
is missing, in which case the LineFormatter should be preferred.