Adding the Form default theme files to be warmed up in Twig's cache #24608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't it be merged in 2.7 as well? |
fabpot
reviewed
Oct 18, 2017
| $coreThemePath = dirname(dirname($reflClass->getFileName())).'/Resources/views/Form'; | ||
| $container->getDefinition('twig.loader.native_filesystem')->addMethodCall('addPath', array($coreThemePath)); | ||
|
|
||
| $paths = $container->getParameter('twig.cache_warmer_paths'); |
There was a problem hiding this comment.
I don't like the use of a parameter. That exposes internal details.
3e346d9 to
2ef619f
Compare
|
Ok, fixed back to not introduce a new parameter. I just tried again, it still works fine. This applies only to 2.8 and above. In 2.7, the cache warmer doesn't have a third (paths) argument at all: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/TwigBundle/Resources/config/twig.xml#L48 So... it could technically be fixed in 2.7, but would be much different than this patch... the paths arg from 2.8 would need to be backported. Should we? |
nicolas-grekas
approved these changes
Oct 19, 2017
fabpot
approved these changes
Oct 19, 2017
|
Thank you @weaverryan. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2017
…g's cache (weaverryan) This PR was merged into the 2.8 branch. Discussion ---------- Adding the Form default theme files to be warmed up in Twig's cache | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | not needed Hiya guys! So..... during a Symfony Live workshop, we found out that the form theme Twig templates are *not* included in the Twig cache warmup process. This fixes that. I believe this is the only "weird" case where we use a Twig template that is not in a bundle and also not added to Twig as a proper namespaces. I tested this on a 2.8 project. Before the patch, the form theme templates were not warmed up. After, they are warmed up. Booya. Cheers! Commits ------- 2ef619f Adding the Form default theme files to be warmed up in Twig's cache
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hiya guys!
So..... during a Symfony Live workshop, we found out that the form theme Twig templates are not included in the Twig cache warmup process. This fixes that. I believe this is the only "weird" case where we use a Twig template that is not in a bundle and also not added to Twig as a proper namespaces.
I tested this on a 2.8 project. Before the patch, the form theme templates were not warmed up. After, they are warmed up. Booya.
Cheers!