[Security] Fix missing BC layer for AbstractGuardAuthenticator::getCredentials() #24624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be16ddc to
8ca83a4
Compare
ogizanagi
approved these changes
Oct 19, 2017
|
Do we have a deprecation message when not implementing the new interface btw ? I don't see it in this code. |
8ca83a4 to
b6bb84b
Compare
|
@stof we have https://github.com/symfony/symfony/blob/3.4/src/Symfony/Component/Security/Guard/GuardAuthenticatorInterface.php#L32 which should be enough (per #16835 (comment)). |
|
Thank you @chalasr. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 24, 2017
…ator::getCredentials() (chalasr) This PR was merged into the 3.4 branch. Discussion ---------- [Security] Fix missing BC layer for AbstractGuardAuthenticator::getCredentials() | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a If a guard authenticator extends `AbstractGuardAuthenticator` and returns `null` from `getCredentials()`, an `\UnexpectedValueException` is thrown when upgrading to 3.4 because the abstract already implements the new interface. This triggers a deprecation notice instead. Commits ------- b6bb84b [Security] Fix BC layer for AbstractGuardAuthenticator subclasses
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a guard authenticator extends
AbstractGuardAuthenticatorand returnsnullfromgetCredentials(), an\UnexpectedValueExceptionis thrown when upgrading to 3.4 because the abstract already implements the new interface.This triggers a deprecation notice instead.