[Form] Fix FormEvents::* constant and value matching #24631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yceruto
commented
Oct 19, 2017
•
| Q | A |
|---|---|
| Branch? | 4.0 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes (ppl relying on const value directly, very weird) |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24615 |
| License | MIT |
| Doc PR | - |
|
Should this be mentioned inside |
|
Thanks @dmaicher, done. |
fe514e0 to
0ee856a
Compare
javiereguiluz
approved these changes
Oct 19, 2017
|
Thanks a lot @javiereguiluz, much better! :) |
ro0NL
reviewed
Oct 19, 2017
| * The values of the `FormEvents::*` constants have been updated to match the | ||
| constant names. You should only update your application if you relied on the | ||
| constant values instead of their names. | ||
|
|
There was a problem hiding this comment.
This will cause UPGRADE-4.0 in master and 3.4 going out of sync no? Which btw is already happening (https://www.diffchecker.com/5W6GeCnZ).. again :-)
There was a problem hiding this comment.
So the upgrade entry should be updated in 3.4 too?
ogizanagi
approved these changes
Oct 19, 2017
|
Thank you @yceruto. |
fabpot
added a commit
that referenced
this pull request
Oct 19, 2017
…yceruto, javiereguiluz) This PR was merged into the 4.0-dev branch. Discussion ---------- [Form] Fix FormEvents::* constant and value matching | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | no | New feature? | no | BC breaks? | yes (ppl rely on const value directly, very weird) | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24615 | License | MIT | Doc PR | - > #24615 (comment) by @stof: Yeah, I think we could change this in 4.0 without a big impact (btw, I think our BC policy even allows it for this case). There is one case where people will use the event name rather than the constant: the kernel.event_listener tag (and recent versions can even use the constant in YAML files). But this won't be the case for this event, as form events are not dispatched in the main dispatcher anyway. Commits ------- 944931a Minor reword 0ee856a Update UPGRADE-4.0.md 0fc2282 fix the constant value to be consistent with the name
fabpot
added a commit
that referenced
this pull request
Oct 19, 2017
This PR was merged into the 3.4 branch. Discussion ---------- Synchronizing Upgrade 4.0 notes in 3.4 | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24631 (comment) | License | MIT | Doc PR | - Commits ------- c4f64a6 Update UPGRADE-4.0.md
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.