[DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring #24671
Conversation
| @@ -290,7 +292,7 @@ private function getAutowiredReference(TypedReference $reference, $deprecationMe | |||
| return new TypedReference($this->types[$type], $type); | |||
There was a problem hiding this comment.
shouldn't we have a deprecation warning triggered here, to tell people to register the type for the new system rather than relying on old types (as you disable the loading in strict mode)
There was a problem hiding this comment.
They will get an exception saying that. Not sure there is anything else needed.
There was a problem hiding this comment.
@stof I re-enabled by-explicit-autowiring-type in strict mode, that should address your concern, isn't it?
|
wouldn't this cause issues to use a parameter for that ? Wouldn't any bundle be free to overwrite it ? |
that's true, but is this really an issue? |
Well, that's precisely the reason why our defaults are file-level. |
|
Well ok. But we always advertised autowiring as a bad idea for bundles before 3.3. I don't think this would be an issue. |
|
I think this is important as we already got several reports by ppl being biten by autoregistration. |
1648936 to
a4a0ae2
Compare
…t from legacy autowiring (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - To preserve BC, autowiring still wires things in hybrid 2.8/3.3 modes. But 2.8 mode is really a foot gun. I propose to add a new parameter in SF3.4, to opt-out of this 2.8 mode, and enable this strict mode for all new projects. WDYT? (see symfony/recipes#221 for corresponding change on Flex recipe) Commits ------- a4a0ae2 [DI] Handle container.autowiring.strict_mode to opt-out from legacy autowiring
To preserve BC, autowiring still wires things in hybrid 2.8/3.3 modes.
But 2.8 mode is really a foot gun.
I propose to add a new parameter in SF3.4, to opt-out of this 2.8 mode, and enable this strict mode for all new projects.
WDYT?
(see symfony/recipes#221 for corresponding change on Flex recipe)