Fix $_ENV/$_SERVER precedence in test framework #24686
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Oct 25, 2017
ogizanagi
approved these changes
Oct 25, 2017
chalasr
approved these changes
Oct 25, 2017
|
Shouldn't we also change the precedence in src/Symfony/Component/DependencyInjection/Container.php? |
|
I've made the change in Container.php for better consistency. Should be ready now. |
javiereguiluz
approved these changes
Oct 26, 2017
fabpot
added a commit
that referenced
this pull request
Oct 26, 2017
This PR was merged into the 3.3 branch. Discussion ---------- Fix $_ENV/$_SERVER precedence in test framework | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a When defining env vars values in `phpunit.xml.dist`, we are using `<env ...>`. PHPUnit registers those env vars in `$_ENV`, but not in `$_SERVER`. This means that those values might not be used by Symfony if env vars defined in `.env` are automatically registered (which is my case). In any case, I think it makes sense to make `$_ENV` take precedence as this is how we register them in `phpunit.xml.dist`. Commits ------- 6ed9919 fixed $_ENV/$_SERVER precedence in test framework
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining env vars values in
phpunit.xml.dist, we are using<env ...>. PHPUnit registers those env vars in$_ENV, but not in$_SERVER. This means that those values might not be used by Symfony if env vars defined in.envare automatically registered (which is my case).In any case, I think it makes sense to make
$_ENVtake precedence as this is how we register them inphpunit.xml.dist.