[HttpFoundation] Fix caching of session-enabled pages #24691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Oct 25, 2017
| Q | A |
|---|---|
| Branch? | 3.4 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #24690 |
| License | MIT |
| Doc PR | - |
Tobion
reviewed
Oct 26, 2017
| @@ -101,6 +102,7 @@ public function __construct(array $options = array(), $handler = null, MetadataB | |||
| { | |||
| $options += array( | |||
| 'cache_limiter' => 'private_no_expire', | |||
| 'cache_expire' => 0, | |||
There was a problem hiding this comment.
Can't you then use cache_limiter => nocache directly. The only difference is that it also sets no-store, meaning no conditional requests.
There was a problem hiding this comment.
No-store is too aggressive to me, conditional requests are fine, aren't they?
Tobion
approved these changes
Oct 26, 2017
|
Thank you @nicolas-grekas. |
Tobion
added a commit
that referenced
this pull request
Oct 26, 2017
…olas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [HttpFoundation] Fix caching of session-enabled pages | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24690 | License | MIT | Doc PR | - Commits ------- 572e02c [HttpFoundation] Fix caching of session-enabled pages
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.