[TwigBridge] Bootstrap 4 form theme fixes #24703
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not add .form-control-label and .col-form-legend at the same time. It's enough to have only one of them.
I think it makes more sense to have nested `fieldset`s than `label`s without `for`. An example of nested fieldsets is given at the bottom of [this page](https://dev.w3.org/html5/spec-preview/the-fieldset-element.html).
|
Btw, can we safely remove the |
fabpot
approved these changes
Oct 29, 2017
|
Thank you @vudaltsov. |
fabpot
added a commit
that referenced
this pull request
Oct 29, 2017
This PR was squashed before being merged into the 3.4 branch (closes #24703). Discussion ---------- [TwigBridge] Bootstrap 4 form theme fixes | Q | A | ------------- | --- | Branch? | 3.4 and higher | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Some fixes for compound forms and their labels. 1. Do not add `.form-control-label` and `.col-form-legend` at the same time. It's enough to have only one of them. 1. Use legends instead of labels for compound fields. I think it makes more sense to have nested `fieldsets` than `labels` without `for` in a compound form. An example of nested fieldsets is given at the bottom of [this page](https://dev.w3.org/html5/spec-preview/the-fieldset-element.html). Commits ------- e55c67a [TwigBridge] Bootstrap 4 form theme fixes
|
@vudaltsov could you please check tests? They are failing in relation to this PR I suppose. |
|
i fixed them in #24728 |
|
@arkste , thanx a lot. |
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fixes for compound forms and their labels.
.form-control-labeland.col-form-legendat the same time. It's enough to have only one of them.fieldsetsthanlabelswithoutforin a compound form. An example of nested fieldsets is given at the bottom of this page.