[Workflow] Add PlantUML dumper to workflow:dump command #24705

Plopix · 2017-10-27T03:22:27Z

Q	A
Branch	4.1
Bug fix	no
New feature	yes
BC breaks?	no
Deprecations?	no
Tests pass?	yes
License	MIT
Doc PR	symfony/symfony-docs#9220

Hello,

workflow:dump exports workflows in dot format. To me, this format is not the easiest and not the simplest to use. Styles and logic are mixed together which makes it hard to read.

PlantUML is a tool based on Graphviz like Dot but that
generates nicer diagrams, more readable and most of all easier to adapt to your
documentation. Just copy and paste the PUML on the website you will see the rendering live.

Also, there is a PHPStorm Plugin and plenty of integration of this format.

This PR adds 2 options

a --dump-format=puml option to the workflow:dump command to generate the workflows in PlantUML.

The conversion requires the PlantUML JAR, and can be used like that:

php bin/console workflow:dump pull_request --dump-format=puml | java -jar plantuml.jar -p  > workflow.png

don't forget the -p to enable the "piping"

Here is an example with pull_request workflow of the documentation (with no style and no marking):

@startuml
title pull_request
state start <<initial>>
state coding
state travis
state review
state merged
state closed
start --> travis: submit
coding --> travis: update
travis --> travis: update
review --> travis: update
travis --> review: wait_for_review
review --> coding: request_change
review --> merged: accept
review --> closed: reject
closed --> review: reopen
@enduml

As PlantUML let us define styles, I have provided some by default that the user can override.
Adding some marking:

php bin/console workflow:dump pull_request travis review --dump-format=puml

will give us:

@startuml
sprite $sf_logo [81x20/16z] {
hPNRaYiX24K1xwBo_tyx6-qaCtDEJ-KXLYMTLbp0HWcHZr3KRDJ8z94HG3jZn4_mijbQ2ryJoFePtXLWA_qxyGy19DpdY_10z11ZAbGjFHRwcEbcKx5-wqsV
yIMo8StMCHKh8ZUxnEwrZiwRAUOvy1lLcPQF4lEFAjhzMd5WOAqvKflS0Enx8PbihiSYXM8ClGVAseIWTAjCgVSAcnYbQG79xKFsZ0VnDCNc7AVBoPSMcTsX
UnrujbYjjz0NnsObkTgnmolqJD4QgGUYTQiNe8eIjtx4b6Vv8nPGpncn3NJ8Geo9W9VW2wGACm_JzgIO8A8KXr2jUBCVGEAAJSZ6JUlsNnmOzmIYti9G7bjL
8InaHM9G40NkwTG7OxrggvNIejA8AZuqyWjOzTIKi-wwYvjeHYesSWuPiTGDN5THzkYLU4MD5r2_0PDhG7LIUG33z5HtM6CP3icyWEVOS61sD_2ZsBfJdbVA
qM53XHDUwhY0TAwPug3OG9NonRFhO8ynF3I4unuAMDHmSrXH57V1RGvl9jafuZF9ZhqjWOEh98y0tUYGsUxkBSllIyBdT2oM5Fn2-ut-fzsq_cQNuL6Uvwqr
knh4RrvOKzxZfLV3s0rs_R_1SdYt3VxeQ1_y2_W2
}
title pull_request
skinparam titleBorderRoundCorner 15
skinparam titleBorderThickness 2
skinparam state {
    BackgroundColor<<initial>> #87b741
    BackgroundColor<<marked>> #3887C6
    BorderColor #3887C6
    BorderColor<<marked>> Black
    FontColor<<marked>> White
}
state start <<initial>>
state coding
state travis <<marked>>
state review <<marked>>
state merged
state closed
start --> travis: submit
coding --> travis: update
travis --> travis: update
review --> travis: update
travis --> review: wait_for_review
review --> coding: request_change
review --> merged: accept
review --> closed: reject
closed --> review: reopen
footer \nGenerated by <$sf_logo> **Workflow Component** and **PlantUML**
@enduml

Which gives you that:

With square as transition, it gives you that:

Hope you will find that interesting!

Plopix · 2017-10-27T04:36:50Z

That is failing on Windows, but I don't really know why, probably a weird Windows specificity, or the END OF LINE?
You might have an idea?

Thanks!

stloyd · 2017-10-27T07:11:04Z

src/Symfony/Component/Workflow/CHANGELOG.md

@@ -1,6 +1,10 @@
 CHANGELOG
 =========

+3.5.0


It will be 4.1.0 not 3.5.0 (which never will be released)

stloyd · 2017-10-27T07:11:43Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+        }
+
+        return
+            '@startuml'.PHP_EOL.static::SYMFONY_LOGO.PHP_EOL;


Should be in previous line.

stloyd · 2017-10-27T07:14:12Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    const MARKED = 'marked';
+
+    const SYMFONY_LOGO = 'sprite $sf_logo [81x20/16z] {


Better & probably safer than string comparison would be to save them as fixtures & compare results with pregenerated fixture.

I am not sure I understand here what you are proposing. Can you tell me more and I will be happy to change.

I think I got it and I made changes accordingly.

Plopix · 2017-10-28T21:59:38Z

I fixed the comment 9 (cc @stloyd)
appveyor build is passing now
travis-ci build fails because of VarDumper (that is not related to this PR cc @nicolas-grekas)

@Nyholm or @lyrixx
Question/Note: The current workflow:dump does not generate the same way workflow and state machine. Is that a standard? I feel that it is so much more readable with transition names on the arrows. Is that something you want me to add on the PR? I am not a graph expert and it might be a convention or something.

nicolas-grekas · 2017-10-28T22:12:15Z

DST time, transient failure will be fixed tomorrow hopefully :)

lyrixx · 2017-11-07T16:31:48Z

Question/Note: The current workflow:dump does not generate the same way workflow and state machine. Is that a standard?

Oups Sorry I forgot to reply.

Yes it's wanted. As a state machine can have many transition with the same name, the graph could be very ugly. that's why we did this.

lyrixx · 2017-11-07T16:32:36Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

        } else {
            throw new \InvalidArgumentException(sprintf('No service found for "workflow.%1$s" nor "state_machine.%1$s".', $serviceId));
        }

+        /** @var \Symfony\Component\Workflow\Workflow $workflow */


Looks like it's useless

not for PHPStorm ;) but I can remove it

Plopix · 2017-11-08T05:43:57Z

@lyrixx I have added an option to let the user decide which transition he wants.
I hope that is fine for you! Because to me, the square as transition kind of complexify sometimes too. It is great to have the option.

lyrixx · 2017-11-08T13:46:02Z

Thanks. I will try your PR as soon as possible ;)

nicolas-grekas · 2017-12-08T19:43:55Z

@lyrixx time to review? :)

Simperfit · 2017-12-09T15:24:42Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    public function __construct($transitionType)
+    {
+        $this->transitionType = static::DEFAULT_TRANSITION_TYPE;


You don't need to do this since it's already defaulted when you do $input->getOption('transition')

I agree but this class could be used differently and without the command then I think it is correct to initialize it. no?

Why not using

protected $transitionType = self::DEFAULT_TRANSITION_TYPE;

instead ?
I may be missing something but it feels better to me.

No that is me, I don't know I wanted to avoid that because of php versions but now for 4.x it is php 7 then we are all good to do that. And I think we were good before too...I was wrong. It is better now ;)

Simperfit · 2017-12-09T15:26:42Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+    public function __construct($transitionType)
+    {
+        $this->transitionType = static::DEFAULT_TRANSITION_TYPE;
+        if ($transitionType == static::SQUARE_TRANSITION_TYPE) {


if (static::SQUARE_TRANSITION_TYPE === $transitionType)

same as above comment

Simperfit · 2017-12-09T15:26:55Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    protected function isSquareTransitionType()
+    {
+        return $this->transitionType == static::SQUARE_TRANSITION_TYPE;


why not === ?

ok will change

Simperfit · 2017-12-09T15:32:10Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+                $code[] = "agent {$transition->getName()}";
+            }
+        }
+        foreach ($definition->getTransitions() as $transition) {


It feels like alot of complexity comparing to the GraphvizDumper, isn't in the class something you could re-use to get arrays and then transform them directly ?

Not really sure I get what you want me to do. I agree it is not really straightforward but it is an efficient way to manage both TransitionType, GraphvizDumper as 2 classes to do that. I did not see the value for the PlantUML one, and I still don't see it. (but I would love to have your opinion)

I could do that in another method and then merge arrays... is it what you would like?.

Let me know!

Thank you!

I was just thinking on how much this adds complexity. I guess if merging the arrays cost more in performance than what you are doing here let's keep this. (I think it will be anyway).

I just wanted to know more about this ;).

Plopix · 2017-12-12T01:16:26Z

I have updated the PR and rebased. Not sure why the tests are failing I think it is not related to this code, master code is failing too.

Simperfit · 2017-12-12T06:52:30Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    public function __construct($transitionType = null)
+    {
+        if ($transitionType === static::SQUARE_TRANSITION_TYPE) {


You should use yoda style, btw I don't know if it's really needed to do this

yoda style done.

it is a way to kind of enforcing the 2 types and those 2 type only the default one or square
It would work without, but the value of transitionType could be inconsistent. Let me know your thoughts

Simperfit · 2017-12-12T06:52:38Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    protected function isSquareTransitionType()
+    {
+        return $this->transitionType === static::SQUARE_TRANSITION_TYPE;


yoda style please.

Simperfit · 2017-12-12T06:53:50Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+        if (isset($options['name'])) {
+            $code[] = "title {$options['name']}";
+        }
+        if (isset($options['skinparams']) && count($options['skinparams']) > 0) {


I don't think you need to count here

correct I replaced with is_array to ensure the foreach won't fail if someone send something else

Simperfit

Some minor comments, but great improvment thanks !

Plopix · 2017-12-12T07:53:59Z

updated @Simperfit (we are almost there ;) )

lyrixx

I let few comments on the Command Class. It seems you did not test it on real
project :/

And I followed you doc and it does not work. the program open a dialog windows
where I'm supposed to select a folder. I'm a bit lost.

Finally, I'm not sure if plantuml is really mainstream. By default the website
is in French :/ http://plantuml.com/

So for now I'm not sure we want this support in the Core. What do others think?

ping @xabbuh @Nyholm

lyrixx · 2017-12-27T17:29:21Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

@@ -19,6 +19,8 @@
 use Symfony\Component\Workflow\Dumper\GraphvizDumper;
 use Symfony\Component\Workflow\Dumper\StateMachineGraphvizDumper;
 use Symfony\Component\Workflow\Marking;
+use Symfony\Component\Console\Input\InputOption;


Input Option Is already imported.

lyrixx · 2017-12-27T17:29:55Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

@@ -19,6 +19,8 @@
 use Symfony\Component\Workflow\Dumper\GraphvizDumper;
 use Symfony\Component\Workflow\Dumper\StateMachineGraphvizDumper;
 use Symfony\Component\Workflow\Marking;
+use Symfony\Component\Console\Input\InputOption;
+use Symfony\Component\Workflow\Dumper\PlantUmlDumper;


Could you sort all uses?

lyrixx · 2017-12-27T17:32:16Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

@@ -39,13 +41,23 @@ protected function configure()
                new InputArgument('name', InputArgument::REQUIRED, 'A workflow name'),
                new InputArgument('marking', InputArgument::IS_ARRAY, 'A marking (a list of places)'),
                new InputOption('label', 'l', InputArgument::OPTIONAL, 'Labels a graph'),
+                new InputOption('format', null, InputArgument::OPTIONAL, 'The dump format', 'dot'),
+                new InputOption(


We don't do that in Symfony. All arguments should be on one line..

alright, that is fixed.

lyrixx · 2017-12-27T17:32:55Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

@@ -39,13 +41,23 @@ protected function configure()
                new InputArgument('name', InputArgument::REQUIRED, 'A workflow name'),
                new InputArgument('marking', InputArgument::IS_ARRAY, 'A marking (a list of places)'),
                new InputOption('label', 'l', InputArgument::OPTIONAL, 'Labels a graph'),
+                new InputOption('format', null, InputArgument::OPTIONAL, 'The dump format', 'dot'),
+                new InputOption(
+                    'transition',


puml_transition_format

lyrixx · 2017-12-27T17:33:26Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

+                new InputOption(
+                    'transition',
+                    null,
+                    InputArgument::OPTIONAL,


This is wrong:

It's an option, not an arguement

The value is required

correct, fixed.

lyrixx · 2017-12-27T17:34:47Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php


-    %command.full_name% <workflow name> | dot -Tpng > workflow.png
+<info>DOT</info>:  %command.full_name% <workflow name> | dot -Tpng > workflow.png 
+<info>PUML</info>: %command.full_name% <workflow name> --format=puml -p | java -jar plantuml.jar > workflow.png


What is -p ?

That is a typo (not present in the PR doc) the -p, as mentioned in the PR doc is for piping. But it is for plantuml.jar... not for the command. I have fixed that too.

lyrixx · 2017-12-27T17:35:56Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

@@ -39,13 +41,23 @@ protected function configure()
                new InputArgument('name', InputArgument::REQUIRED, 'A workflow name'),
                new InputArgument('marking', InputArgument::IS_ARRAY, 'A marking (a list of places)'),
                new InputOption('label', 'l', InputArgument::OPTIONAL, 'Labels a graph'),
+                new InputOption('format', null, InputArgument::OPTIONAL, 'The dump format', 'dot'),


"The dump format [dot|puml]"

format is a bad name because it's already used in the --help command.
So bin/console workflow:dump article --format=puml -h do not work anymore

good catch I have renamed by dump_format

lyrixx · 2017-12-27T17:36:53Z

src/Symfony/Bundle/FrameworkBundle/Command/WorkflowDumpCommand.php

        } else {
            throw new \InvalidArgumentException(sprintf('No service found for "workflow.%1$s" nor "state_machine.%1$s".', $serviceId));
        }

+        if ('puml' === $format) {
+            $dumper = new PlantUmlDumper($transitionType);
+        } else {


use an else if here

fabpot · 2018-01-23T06:47:25Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+/**
+ * PlantUmlDumper dumps a workflow as a PlantUML file.
+ *
+ * You can convert the generated dot file with the plantuml.jar utility (http://plantuml.com/):


I suppose it does not generate a dot file.

that is correct, I have pushed the correction. thx!

stof · 2018-01-23T09:46:33Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+knh4RrvOKzxZfLV3s0rs_R_1SdYt3VxeQ1_y2_W2
+}';
+    const INITIAL = 'initial';
+    const MARKED = 'marked';


shouldn't some of these be private constants ?

stof · 2018-01-23T09:47:26Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+
+    private function isSquareTransitionType(): bool
+    {
+        return static::SQUARE_TRANSITION_TYPE === $this->transitionType;


use self:: to access constant. There is no reason to make them an extension point by allowing changing their values (and the code would not work anyway in such case, due to other places)

stof · 2018-01-23T09:47:39Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+            return $start;
+        }
+
+        return $start.static::SYMFONY_LOGO.PHP_EOL;


self: here as well

stof · 2018-01-23T09:48:41Z

src/Symfony/Component/Workflow/Dumper/PlantUmlDumper.php

+            return $end;
+        }
+
+        return PHP_EOL.'footer \nGenerated by <$sf_logo> **Workflow Component** and **PlantUML**'.$end;


Are you sure about the \n here, which is not a newline char ?

yes I think so, the \n is working as expected.

stof · 2018-01-23T09:53:06Z

The dump of the workflow in #24705 (comment) looks confusing to me. It looks like there are 2 independant publish transitions, allowing to go one path or the other, while it is actually a single transition with 2 inputs (meaning that it is a AND between both paths, not a OR). This is exactly the reason why the dot dumper uses boxes to represent transitions, not arrows (to allow having multiple inputs and multiple outputs for each of them).
This is the main difference between a generic workflow and a state machine (the state machine has only one input and one output for each transition)

lyrixx · 2018-01-23T11:07:55Z

Oh @stof Is totally right. This PR could not be merged in this state.

stof · 2018-01-23T14:04:12Z

The current dumper is fine for the case of state machines though

Plopix · 2018-01-23T22:10:09Z

@stof thank you I have updated the code.
About the confusion, well as I said before, I am not an expert on workflow/state_machine, I was just trying to provide a better dump.

From my point of view, I don't find it that confusing as I know that I can have only one transition with the same name, then it must be the same.

You said:

This is the main difference between a generic workflow and a state machine (the state machine has only one input and one output for each transition)

But here: https://symfony.com/doc/current/workflow/state-machines.html
update gets multiple 'from'

The PR is aiming to let the choice to the user to dump it with arrow or square transition.
I have compared closely the dumps with Dot and PlantUML

On the cases provided in the doc and on the article workflow of @lyrixx :
(for each I dumped with Dot, PlantUML square and arrow transition)

Pull Request: https://symfony.com/doc/current/workflow/state-machines.html

Blog Publishing: https://symfony.com/doc/current/workflow/usage.html

Article: https://github.com/lyrixx/SFLive-Paris2016-Workflow/blob/master/config/packages/workflow.yaml#L3

I think that is working, I am not sure what you are expecting, I see at least 3 options in which we could go:

1/ we could force square for workflow and arrow for state_machine
2/ we could put by default square for workflow and arrow for state_machine
3/ don't do change anything as the user has the choice already

Let me know

lyrixx · 2018-01-24T09:19:38Z

1/ we could force square for workflow and arrow for state_machine

It's definitively the way to go ;)

Plopix · 2018-01-25T08:13:48Z

hey @lyrixx @stof I have done the option 1/

For the sake of my understanding, I would love if you could you explain why "arrows" are not valid sometimes?

In this example, for instance, it feels simpler to have arrows. But I would understand if the reason is to force a kind of consistency for each type.

Let me know!

lyrixx · 2018-01-26T09:43:01Z

As you can see on the previous schema, If you don't draw the transition (square), you have no way to know how many transition there are. And of course the 2 workflows (line 1 and line 2) are totally different.

Plopix · 2018-01-26T18:46:39Z

ok makes sense ;-) all good to merge then maybe ;-)

fabpot · 2018-02-07T05:49:20Z

Thank you @Plopix.

…d (Plopix) This PR was merged into the 4.1-dev branch. Discussion ---------- [Workflow] Add PlantUML dumper to workflow:dump command | Q | A | ------------- | --- | Branch | 4.1 | Bug fix | no | New feature | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT | Doc PR | Will do depending on the comments about that PR Hello, `workflow:dump` exports workflows in `dot` format. To me, this format is not the easiest and not the simplest to use. Styles and logic are mixed together which makes it hard to read. [PlantUML](http://plantuml.com/) is a tool based on Graphviz like Dot but that generates nicer diagrams, more readable and most of all easier to adapt to your documentation. Just copy and paste the PUML on the website you will see the rendering live. Also, there is a [PHPStorm Plugin](https://plugins.jetbrains.com/plugin/7017-plantuml-integration) and [plenty of integration](http://plantuml.com/running) of this format. This PR adds 2 options * a `--dump-format=puml` option to the `workflow:dump` command to generate the workflows in PlantUML. * a `--puml-transition-format=square|arrow` option to the `workflow:dump` command to generate the workflows in PlantUML using a square shape or arrow for the transition. (see below) The conversion requires the PlantUML JAR, and can be used like that: ```bash php bin/console workflow:dump pull_request --dump-format=puml | java -jar plantuml.jar -p > workflow.png ``` > don't forget the `-p` to enable the "piping" Here is an example with `pull_request` workflow of the documentation (with no style and no marking): ``` @startuml title pull_request state start <<initial>> state coding state travis state review state merged state closed start --> travis: submit coding --> travis: update travis --> travis: update review --> travis: update travis --> review: wait_for_review review --> coding: request_change review --> merged: accept review --> closed: reject closed --> review: reopen @enduml ``` As PlantUML let us define styles, I have provided some by default that the user can override. Adding some marking: ```bash php bin/console workflow:dump pull_request travis review --dump-format=puml ``` will give us: ``` @startuml sprite $sf_logo [81x20/16z] { hPNRaYiX24K1xwBo_tyx6-qaCtDEJ-KXLYMTLbp0HWcHZr3KRDJ8z94HG3jZn4_mijbQ2ryJoFePtXLWA_qxyGy19DpdY_10z11ZAbGjFHRwcEbcKx5-wqsV yIMo8StMCHKh8ZUxnEwrZiwRAUOvy1lLcPQF4lEFAjhzMd5WOAqvKflS0Enx8PbihiSYXM8ClGVAseIWTAjCgVSAcnYbQG79xKFsZ0VnDCNc7AVBoPSMcTsX UnrujbYjjz0NnsObkTgnmolqJD4QgGUYTQiNe8eIjtx4b6Vv8nPGpncn3NJ8Geo9W9VW2wGACm_JzgIO8A8KXr2jUBCVGEAAJSZ6JUlsNnmOzmIYti9G7bjL 8InaHM9G40NkwTG7OxrggvNIejA8AZuqyWjOzTIKi-wwYvjeHYesSWuPiTGDN5THzkYLU4MD5r2_0PDhG7LIUG33z5HtM6CP3icyWEVOS61sD_2ZsBfJdbVA qM53XHDUwhY0TAwPug3OG9NonRFhO8ynF3I4unuAMDHmSrXH57V1RGvl9jafuZF9ZhqjWOEh98y0tUYGsUxkBSllIyBdT2oM5Fn2-ut-fzsq_cQNuL6Uvwqr knh4RrvOKzxZfLV3s0rs_R_1SdYt3VxeQ1_y2_W2 } title pull_request skinparam titleBorderRoundCorner 15 skinparam titleBorderThickness 2 skinparam state { BackgroundColor<<initial>> #87b741 BackgroundColor<<marked>> #3887C6 BorderColor #3887C6 BorderColor<<marked>> Black FontColor<<marked>> White } state start <<initial>> state coding state travis <<marked>> state review <<marked>> state merged state closed start --> travis: submit coding --> travis: update travis --> travis: update review --> travis: update travis --> review: wait_for_review review --> coding: request_change review --> merged: accept review --> closed: reject closed --> review: reopen footer \nGenerated by <$sf_logo> **Workflow Component** and **PlantUML** @enduml ``` Which gives you that: ![workflow](https://user-images.githubusercontent.com/313532/32086584-253e39c0-ba8b-11e7-82c7-fa24309dbcd6.png) With `square` as transition, it gives you that: ![workflow](https://user-images.githubusercontent.com/313532/32533123-a8ea4530-c403-11e7-8f88-4f18d5e23a28.png) Hope you will find that interesting! Commits ------- 1497d36 Add option to the workflow:dump command to allow PlantUML format dump

lyrixx · 2018-02-07T09:55:19Z

👏 Thanks for your hard work on this feature. I just tested it and it works very well.

This PR was submitted for the 4.0 branch but it was merged into the master branch instead (closes #9220). Discussion ---------- [Workflow] PlantUML Dump documentation Documentation related to symfony/symfony#24705 This PR aims to explain that the PlantUML dump format is available. Platform.sh URL: http://pr-9220-x7nzdnq-6qmocelev2lwe.eu.platform.sh/workflow/dumping-workflows.html Commits ------- b62d961 [Workflow] PlantUML Dump documentation

carsonbot added Status: Needs Review Workflow labels Oct 27, 2017

stloyd reviewed Oct 27, 2017

View reviewed changes

nicolas-grekas added this to the 4.1 milestone Oct 27, 2017

nicolas-grekas added the Feature label Oct 27, 2017

nicolas-grekas changed the base branch from 3.4 to master October 27, 2017 08:55

lyrixx reviewed Nov 7, 2017

View reviewed changes

Simperfit suggested changes Dec 9, 2017

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Needs Review labels Dec 9, 2017

Simperfit reviewed Dec 12, 2017

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Dec 12, 2017

Simperfit approved these changes Dec 12, 2017

View reviewed changes

lyrixx requested changes Dec 27, 2017

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Dec 27, 2017

fabpot requested changes Jan 23, 2018

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Work labels Jan 23, 2018

lyrixx approved these changes Jan 23, 2018

View reviewed changes

Nyholm approved these changes Jan 23, 2018

View reviewed changes

fabpot approved these changes Jan 23, 2018

View reviewed changes

stof requested changes Jan 23, 2018

View reviewed changes

carsonbot added Status: Needs Work and removed Status: Reviewed labels Jan 23, 2018

Add option to the workflow:dump command to allow PlantUML format dump

1497d36

carsonbot added Status: Reviewed and removed Status: Needs Work labels Feb 4, 2018

nicolas-grekas approved these changes Feb 4, 2018

View reviewed changes

fabpot approved these changes Feb 7, 2018

View reviewed changes

fabpot merged commit 1497d36 into symfony:master Feb 7, 2018

Plopix mentioned this pull request Feb 7, 2018

[Workflow] PlantUML Dump documentation symfony/symfony-docs#9220

Closed

Plopix deleted the 3.4 branch February 7, 2018 07:28

fabpot mentioned this pull request May 7, 2018

Release v4.1.0-BETA1 #27181

Merged


		const MARKED = 'marked';

		const SYMFONY_LOGO = 'sprite $sf_logo [81x20/16z] {

[Workflow] Add PlantUML dumper to workflow:dump command #24705

[Workflow] Add PlantUML dumper to workflow:dump command #24705

Conversation

Plopix commented Oct 27, 2017 • edited Loading

Plopix commented Oct 27, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Plopix commented Oct 28, 2017

nicolas-grekas commented Oct 28, 2017

lyrixx commented Nov 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Plopix commented Nov 8, 2017

lyrixx commented Nov 8, 2017

nicolas-grekas commented Dec 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Plopix commented Dec 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Plopix Dec 12, 2017 • edited Loading

Choose a reason for hiding this comment

Simperfit left a comment • edited Loading

Choose a reason for hiding this comment

Plopix commented Dec 12, 2017

lyrixx left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stof commented Jan 23, 2018

lyrixx commented Jan 23, 2018

stof commented Jan 23, 2018

Plopix commented Jan 23, 2018 • edited Loading

lyrixx commented Jan 24, 2018

Plopix commented Jan 25, 2018

lyrixx commented Jan 26, 2018

Plopix commented Jan 26, 2018 • edited by lyrixx Loading

fabpot commented Feb 7, 2018

lyrixx commented Feb 7, 2018

Plopix commented Oct 27, 2017 •

edited

Loading

Plopix Dec 12, 2017 •

edited

Loading

Simperfit left a comment •

edited

Loading

Plopix commented Jan 23, 2018 •

edited

Loading

Plopix commented Jan 26, 2018 •

edited by lyrixx

Loading