[DependencyInjection] Add the possibility to disable assets via xml #24706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
renatomefi
commented
Oct 27, 2017
•
| Q | A |
|---|---|
| Branch? | 3.3 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | no |
| License | MIT |
| Doc PR | no |
- When trying to disable the assets using xml configuration I realized it wasn't possible, this patch fixes and tests it
- Also added extra tests since the assets being disabled was being tested on both php and yaml Extension tests
df5822e to
0b9258d
Compare
chalasr
approved these changes
Oct 27, 2017
|
@chalasr thanks, will do it shortly |
0b9258d to
24d9375
Compare
24d9375 to
44588fa
Compare
44588fa to
8579e24
Compare
|
@chalasr all done! :) |
|
Thank you @renatomefi. |
nicolas-grekas
added a commit
that referenced
this pull request
Oct 28, 2017
…s via xml (renatomefi) This PR was merged into the 3.3 branch. Discussion ---------- [DependencyInjection] Add the possibility to disable assets via xml | Q | A | ------------- | --- | Branch? | 3.3 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no - When trying to disable the assets using xml configuration I realized it wasn't possible, this patch fixes and tests it - Also added extra tests since the assets being disabled was being tested on both php and yaml Extension tests Commits ------- 8579e24 [FrameworkBundle] Allow to disable assets via framework:assets xml configuration
|
@renatomefi Congrats for your first contrib on Symfony! Nice PR, well done. |
|
Thank you @chalasr :) |
This was referenced Oct 30, 2017
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.