[FrameworkBundle] Do not activate the cache if Doctrine's cache is not present #24743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failures are un-related. But related with the timezone change and VarDumper (wink wink @nicolas-grekas) |
weaverryan
approved these changes
Oct 29, 2017
nicolas-grekas
approved these changes
Oct 29, 2017
fabpot
approved these changes
Oct 29, 2017
|
Thank you @sroze. |
fabpot
added a commit
that referenced
this pull request
Oct 29, 2017
…cache is not present (sroze) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Do not activate the cache if Doctrine's cache is not present | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #24683 | License | MIT | Doc PR | ø Annotations are automatically enabled when the `doctrine/annotations` package is around. These annotations are enabled with the `php_array` cache by default, which require `doctrine/cache`. This PR allow this scenario to happen by disabling the annotation cache when `doctrine/cache` is not present. Commits ------- c5c7a23 Do not activate the cache if Doctrine's cache is not present
This was referenced Oct 30, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotations are automatically enabled when the
doctrine/annotationspackage is around. These annotations are enabled with thephp_arraycache by default, which requiredoctrine/cache.This PR allow this scenario to happen by disabling the annotation cache when
doctrine/cacheis not present.