Skip to content

debug:container --types: Fix bug with non-existent classes #24744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2017
Merged

debug:container --types: Fix bug with non-existent classes #24744

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/Symfony/Bundle/FrameworkBundle/Command/ContainerDebugCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,7 +238,18 @@ public function filterToServiceTypes($serviceId)
return false;
}

// see if the class exists (only need to trigger autoload once)
return class_exists($serviceId) || interface_exists($serviceId, false);
// if the id has a \, assume it is a class
if (false !== strpos($serviceId, '\\')) {
return true;
}

try {
$r = new \ReflectionClass($serviceId);

return true;
} catch (\ReflectionException $e) {
// the service id is not a valid class/interface
return false;
}
}
}