[HttpFoundation] add Early Hints to Reponse to fix test #24764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9d9d56a to
70b68ae
Compare
70b68ae to
c2b4ea2
Compare
|
Travis seems broken.. :( EDIT: travis back up |
chalasr
approved these changes
Oct 31, 2017
c2b4ea2 to
0c913fd
Compare
|
The test uses IANA HTTP codes as data provider, and phpdoc says it should be complete. |
|
Should be merged in 2.7, indeed. 👍 |
0c913fd to
dbc2f7b
Compare
|
PR Rebased |
ogizanagi
approved these changes
Oct 31, 2017
|
You should re-trigger a travis build by amending your commit. |
dbc2f7b to
71ad77a
Compare
|
done @ogizanagi |
fabpot
approved these changes
Oct 31, 2017
|
Thank you @Simperfit. |
fabpot
added a commit
that referenced
this pull request
Oct 31, 2017
…imperfit) This PR was merged into the 2.7 branch. Discussion ---------- [HttpFoundation] add Early Hints to Reponse to fix test | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | not needed This line seems to be needed in order to fix the tests, maybe it has been forgot in merge ? Commits ------- 71ad77a [HttpFoundation] add Early Hints in Reponse to fix test
Merged
This was referenced Nov 5, 2017
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This line seems to be needed in order to fix the tests, maybe it has been forgot in merge ?