[SecurityBundle] Fix the datacollector to properly support decision.object being null #24829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Nov 6, 2017
xabbuh
approved these changes
Nov 6, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Nov 6, 2017
…rt decision.object being null (ogizanagi) This PR was merged into the 3.3 branch. Discussion ---------- [SecurityBundle] Fix the datacollector to properly support decision.object being null | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #24804 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Similar to #23050, when accessing a `Data` clone property through `__get()` and the value is `null` for instance, you'll really get `null` instead of a `Data` instance. The solution is to use `seek` instead whenever we access and try to use `profiler_dump` on a `Data` property that can be a simple scalar like `null` or `false`. AFAIK, `decision.object` is the only one here. Commits ------- 769a5f2 [SecurityBundle] Fix the datacollector to properly support decision.object being null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #23050, when accessing a
Dataclone property through__get()and the value isnullfor instance, you'll really getnullinstead of aDatainstance. The solution is to useseekinstead whenever we access and try to useprofiler_dumpon aDataproperty that can be a simple scalar likenullorfalse. AFAIK,decision.objectis the only one here.