[TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType #24837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 6, 2017
|
Note that this could break user space choice widgets which rely on |
xabbuh
reviewed
Nov 6, 2017
| @@ -105,6 +105,7 @@ | |||
| {%- else -%} | |||
| {%- if not valid -%} | |||
| {%- set attr = attr|merge({class: (attr.class|default('') ~ ' form-control is-invalid')|trim}) %} | |||
| {% set valid = true %} | |||
There was a problem hiding this comment.
What about instead just passing true in the form_widget() call below?
There was a problem hiding this comment.
Yes, that works too. Thanks
fabpot
approved these changes
Nov 9, 2017
|
Thank you @ostrolucky. |
fabpot
added a commit
that referenced
this pull request
Nov 9, 2017
… expanded choiceType (ostrolucky) This PR was merged into the 3.4 branch. Discussion ---------- [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Unfortunately I didn't test #24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice. Before:  After:  Commits ------- 39083a2 [TwigBridge] [Bootstrap 4] Fix validation error design for expanded choiceType
This was referenced Nov 12, 2017
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately I didn't test #24802 with expanded option set to true, sorry about that. Without this fix, it applies form error style twice.
Before:
After:
