[Validator] Fix Costa Rica IBAN format #24900
Conversation
| @@ -57,7 +57,7 @@ class IbanValidator extends ConstraintValidator | |||
| 'CH' => 'CH\d{2}\d{5}[\dA-Z]{12}', // Switzerland | |||
| 'CI' => 'CI\d{2}[A-Z]{1}\d{23}', // Ivory Coast | |||
| 'CM' => 'CM\d{2}\d{23}', // Cameron | |||
| 'CR' => 'CR\d{2}\d{3}\d{14}', // Costa Rica | |||
| 'CR' => 'CR\d{2}0\d{3}\d{14}', // Costa Rica | |||
There was a problem hiding this comment.
not sure this is security related, thus needs to be changed on lower branches. I'd prefer the BC variant.
There was a problem hiding this comment.
Accepting an invalid IBAN is a bug. There's no BC to preserve here.
There was a problem hiding this comment.
Right.. this wont lead to crashing behavior. My bad 👍
There was a problem hiding this comment.
https://bank.codes/iban/structure/costa-rica/ implies it can be any kind of number btw... not sure in practice it's always 0.
There was a problem hiding this comment.
@ro0NL https://www.iban.com/calculate-iban.html - this site does not give you ability to choose Reserve Number. It automatically set it 0.
Also wiki says:
CRkk 0bbb cccc cccc cccc cc
0= always zero
b = bank code
c = Account number
There was a problem hiding this comment.
@ro0NL Ok I leave it like that and point it to 2.7
|
Thank you @Warxcell. |
This PR was squashed before being merged into the 2.7 branch (closes #24900). Discussion ---------- [Validator] Fix Costa Rica IBAN format | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | no | License | MIT | Doc PR | no Fix Costa Rica IBAN format: https://bank.codes/iban/structure/costa-rica/ Commits ------- b9b5e18 [Validator] Fix Costa Rica IBAN format
Fix Costa Rica IBAN format: https://bank.codes/iban/structure/costa-rica/