Skip to content

[DI] Friendlier name for generated container in "as_files" mode #24922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2017

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Noticed while looking at Blackfire profiles of a 3.4 app.
Gives friendlier profiles/stack traces.

@fabpot
Copy link
Member

fabpot commented Nov 12, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7db5d40 into symfony:3.4 Nov 12, 2017
fabpot added a commit that referenced this pull request Nov 12, 2017
…s" mode (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Friendlier name for generated container in "as_files" mode

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Noticed while looking at Blackfire profiles of a 3.4 app.
Gives friendlier profiles/stack traces.

Commits
-------

7db5d40 [DI] Friendlier name for generated container in "as_files" mode
@nicolas-grekas nicolas-grekas deleted the di-name branch November 20, 2017 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants