[FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands #24943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecated translation.loader in commands
chalasr
approved these changes
Nov 13, 2017
fabpot
approved these changes
Nov 13, 2017
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Nov 13, 2017
…ead of deprecated translation.loader in commands (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget to update UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A to get rid of the following deprec: > The class "Symfony\Bundle\FrameworkBundle\Translation\TranslationLoader" is deprecated since version 3.4 and will be removed in 4.0. Use "Symfony\Component\Translation\Reader\TranslationReader" Commits ------- 8da283b [FrameworkBundle] Wire the translation.reader service instead of deprecated translation.loader in commands
|
@ogizanagi I'm still seeing a deprecation message when building the container. |
|
@kbond : This is not released yet. Did you apply this patch locally but still having this deprec? |
|
Yes, latest 3.4 branch |
|
Could you please check for occurrences of |
|
No and I see it on a fresh symfony-standard app (downloaded 3.4, ran composer update, enabled translation in |
|
I was able to stop the dep message by removing this line: But I'm not sure why that worked... |
|
I've opened #24959 to keep track of this. Thanks for the report. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to get rid of the following deprec: